Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI command and API call optimization #471

Open
standlove opened this issue Jan 18, 2019 · 2 comments
Open

CLI command and API call optimization #471

standlove opened this issue Jan 18, 2019 · 2 comments

Comments

@standlove
Copy link
Collaborator

standlove commented Jan 18, 2019

Now anything we enter in CLI will cause the whole page refreshed.

This is unnecessary. Failed commands and GET commands should NOT cause refresh.
And if the command won't affect the tree, no need to fetch the tree data as well.

The point is the front-end should make as less API calls as possible.

@standlove standlove changed the title CLI command optimization CLI command and API call optimization Jan 18, 2019
@standlove
Copy link
Collaborator Author

standlove commented Jan 18, 2019

Similarly, when user add/update/delete values for list, set, ordered-set, map or string, no need to refresh the tree. You can get the updated-count for the changed key, and set the value to the affected tree node directly.

@standlove
Copy link
Collaborator Author

Actually the tree should only be reloaded in two cases: open the page first time and user clicks the refresh button.

In all other cases, try to update the tree nodes directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant