Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No response #9

Closed
adamrzanek opened this issue Jan 4, 2021 · 8 comments
Closed

No response #9

adamrzanek opened this issue Jan 4, 2021 · 8 comments
Labels
bug Something isn't working

Comments

@adamrzanek
Copy link

adamrzanek commented Jan 4, 2021

So far your plugin doesn't work for 2h and 3h for me... Nut i'm hoping to use it in the future :)

@adamrzanek adamrzanek added the bug Something isn't working label Jan 4, 2021
@torifat
Copy link
Owner

torifat commented Jan 4, 2021

Can you please share your device models (zhimi.airpurifier.mb3) and the errors you are getting.

For 2H, I created #10 and will fix it soon.

And, I'm not sure where did you find a 4H device - https://www.google.com/search?hl=en&q=xiaomi%20mi%20air%20purifier%204h

@adamrzanek
Copy link
Author

@torifat sorry i mean 3h - my bad

@adamrzanek
Copy link
Author

Did you consider to add led controll and pm2,5 breakpoints?

@torifat
Copy link
Owner

torifat commented Jan 4, 2021

sorry i mean 3h - my bad

Can you please share the error you are getting

Did you consider to add led control and pm2,5 breakpoints?

I thought about adding option to define custom breakpoints for pm2.5. But, I haven't found a good way to add LED control. I didn't like the way other plugins added it as a lightbulb 💡.

@adamrzanek
Copy link
Author

adamrzanek commented Jan 4, 2021 via email

@torifat
Copy link
Owner

torifat commented Jan 4, 2021

You are welcome. I will give you a ping once I have a fix for 2H.

@torifat torifat closed this as completed Jan 4, 2021
@adamrzanek
Copy link
Author

sorry i mean 3h - my bad

Can you please share the error you are getting

Did you consider to add led control and pm2,5 breakpoints?

I thought about adding option to define custom breakpoints for pm2.5. But, I haven't found a good way to add LED control. I didn't like the way other plugins added it as a lightbulb 💡.

I think it doesn’t look bad with this plugin

5A437ED0-38C4-4F19-B3FA-84A0D9EABC6C

@torifat
Copy link
Owner

torifat commented Jan 5, 2021

I think it doesn’t look bad with this plugin

ok, you convinced me. I will add it soon 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants