Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache for streams #51

Open
FichteFoll opened this issue Dec 6, 2018 · 2 comments
Open

Cache for streams #51

FichteFoll opened this issue Dec 6, 2018 · 2 comments

Comments

@FichteFoll
Copy link

With the addition of the cache bar (and maybe some time earlier because I probably haven't updated in a while before that), I no longer see the progress bar for streams (by default).

With the addition of demuer_cache_state or however else the cache being visualized is read, it would be nice if you could see for running streams how much you can seek ahead and behind in the cache, however.

Since that is only interesting when you want to seek, it doesn't need to be active all the time (same as currently), but it would be nice if some sort of visualization was shown on hover. And the exact time remaining in the cache (ahead).

@torque
Copy link
Owner

torque commented Dec 6, 2018

Ironically, the current behavior was implemented as a result of #14, which you filed.

The main issue with displaying anything during a stream of unknown duration is that there isn't a reference to scale to. There are two display options that I can think of.

One option is to scale the cache bar to the current playback position, which I believe is usually accurate even when the duration is unknown. Scaling it in this manner would result in the cache area always being in the right-hand corner of the window and potentially becoming very small for long streams (e.g. 12+hours).

The other option is to scale the currently seekable portion of the cache to the width of the window itself, which immediately reduces its visual usefulness as a display of the amount cached because e.g. 5 seconds of cache and 50 minutes of cache could appear to be visually identical.

Of these two options I think the former is more useful and only breaks down in what I assume are edge cases, though I'm not particularly sold on either of them. Are there other options for scaling/display of this that I haven't considered?

@FichteFoll
Copy link
Author

FichteFoll commented Dec 8, 2018

I know I filed the issue, but the situation was different back then. In the current situation, I do believe this to be useful, and yes, I also believe there are only these two options for scaling, or at least I can only think of those. The former sounds better to be as well.

You didn't mention what you think about setting the inactive bar width to 0 since it hardly has anything to tell for something with unknown length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants