Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publish artifacts step to GitHub Actions workflow #82

Merged
merged 1 commit into from
Aug 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .github/workflows/dotnetcore.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: .NET Core
name: CI

on:
push:
Expand All @@ -11,15 +11,25 @@ on:
jobs:
build:

runs-on: windows-latest
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

- name: Restore
run: dotnet restore

- name: Build
run: dotnet build --configuration Release --no-restore /property:ContinuousIntegrationBuild=True

# - name: Test
# run: dotnet test --configuration Release --no-restore --no-build

- name: Pack
run: dotnet pack --configuration Release --no-restore --no-build
run: dotnet pack --configuration Release --no-restore --no-build -o artifacts

- name: Publish
uses: actions/upload-artifact@v4
with:
name: packages
path: 'artifacts/*.*nupkg'
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net7.0;net8.0</TargetFrameworks>
<TargetFramework>net8.0</TargetFramework>
<RootNamespace>DeviceDetectorNET.RegexEngine.PCRE</RootNamespace>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 0 additions & 2 deletions DeviceDetector.NET.Tests/DeviceDetector.NET.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>

<IsPackable>false</IsPackable>

<RootNamespace>DeviceDetectorNET.Tests</RootNamespace>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions DeviceDetector.NET.Web/DeviceDetector.NET.Web.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<RootNamespace>DeviceDetectorNET.Web</RootNamespace>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion DeviceDetector.NET.sln
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "DeviceDetector.NET.RegexEngine.PCRE", "DeviceDetector.NET.RegexEngine.PCRE\DeviceDetector.NET.RegexEngine.PCRE.csproj", "{94B4F635-61AC-40E4-87CC-DDA4217A0999}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "DeviceDetector.NET.CacheBuilder", "DeviceDetector.Net.CacheBuilder\DeviceDetector.NET.CacheBuilder.csproj", "{E4DA874C-7C29-4D34-9C0E-103073AEE043}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "DeviceDetector.NET.CacheBuilder", "DeviceDetector.NET.CacheBuilder\DeviceDetector.NET.CacheBuilder.csproj", "{E4DA874C-7C29-4D34-9C0E-103073AEE043}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "DeviceDetector.NET.Web", "DeviceDetector.NET.Web\DeviceDetector.NET.Web.csproj", "{04D3C595-50EF-4E7B-8DF6-D5F997F4446D}"
EndProject
Expand Down
7 changes: 6 additions & 1 deletion DeviceDetector.NET/DeviceDetector.NET.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
<Description>The Universal Device Detection library for .NET that parses User Agents and detects devices (desktop, tablet, mobile, tv, cars, console, etc.), clients (browsers, feed readers, media players, PIMs, ...), operating systems, brands and models. This is a port of the popular PHP device-detector library to C#. For the most part you can just follow the documentation for device-detector with no issue.</Description>
<PackageTags>parse detection-library user-agent bot-detection mobile-detection desktop tablet mobile tv cars console standard</PackageTags>
<PackageProjectUrl>https://github.com/totpero/DeviceDetector.NET</PackageProjectUrl>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<AssemblyVersion>6.3.3.0</AssemblyVersion>
<RepositoryUrl>https://github.com/totpero/DeviceDetector.NET</RepositoryUrl>
<SignAssembly>false</SignAssembly>
Expand All @@ -24,6 +23,12 @@
</PackageReleaseNotes>
<PackageIcon>logo.jpg</PackageIcon>
<RepositoryType>git</RepositoryType>

<EmbedUntrackedSources>true</EmbedUntrackedSources>
<IncludeSymbols>true</IncludeSymbols>
<DebugType>portable</DebugType>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>

</PropertyGroup>

<ItemGroup>
Expand Down