Skip to content

Commit f79edf4

Browse files
touhidurabirtouhidurabir
committed
pkp/pkp-lib#10993 update test conditions
1 parent ed56ccd commit f79edf4

File tree

1 file changed

+36
-59
lines changed

1 file changed

+36
-59
lines changed

‎cypress/tests/data/60-content/ZzeddSubmission.cy.js

+36-59
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,6 @@ describe('Data suite tests', function() {
3636
role: 'Volume editor',
3737
}
3838
],
39-
chapters: [
40-
{
41-
'title': 'The Case Studies',
42-
'contributors': ['Michael Power'],
43-
files: ['cases.pdf']
44-
},
45-
{
46-
'title': 'Conclusion',
47-
'contributors': ['Michael Power'],
48-
files: ['conclusion.pdf']
49-
},
50-
],
5139
files: [
5240
{
5341
'file': 'dummy.pdf',
@@ -157,13 +145,12 @@ describe('Data suite tests', function() {
157145
reason: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit.',
158146
},
159147
];
160-
});
161-
162-
it('Registers as author and create submission with several suggested reviewer', function() {
163148

164149
cy.enableReviewerSuggestion();
165150
cy.logout();
151+
});
166152

153+
it('Registers as author and create submission with several suggested reviewer', function() {
167154
cy.register({
168155
'username': 'zzedd',
169156
'givenName': 'Zayan',
@@ -205,7 +192,6 @@ describe('Data suite tests', function() {
205192
cy.get('h2').contains('Submission Details');
206193
cy.setTinyMceContent('titleAbstract-abstract-control-en', submission.abstract);
207194
cy.get('#titleAbstract-title-control-en').click({force: true}); // Ensure blur event is fired
208-
cy.addChapters(submission.chapters);
209195
cy.get('.submissionWizard__footer button').contains('Continue').click();
210196

211197
// Upload files and set file genres
@@ -252,38 +238,24 @@ describe('Data suite tests', function() {
252238

253239
cy.get('.pkpFormField:contains("Given Name")').find('input[name*="-en"]').type('Test');
254240
cy.get('.pkpFormField:contains("Family Name")').find('input[name*="-en"]').type('Suggestion');
255-
cy.get('.pkpFormField:contains("Email")').find('input[name="email"]').type('testsuggestion');
241+
cy.get('.pkpFormField:contains("Email")').find('input[name="email"]').type('testsuggestion@mail.test');
256242
cy.get('.pkpFormField:contains("Affiliation")').find('input[name*="-en"]').type('Test Affiliation');
257243
cy.setTinyMceContent('reviewerSuggestions-suggestionReason-control-en', 'Test suggestion reason');
258244
cy.get('div[role=dialog]:contains("Add Reviewer Suggestion")')
259245
.find('button:contains("Save")')
260246
.click();
261247
cy.wait(3000);
262-
263-
cy.get('#reviewerSuggestions-email-error').contains('This is not a valid email address.');
264-
cy.get('.pkpFormField:contains("email")').find('input[name="email"]').click().focused().clear().type('[email protected]');
265-
cy.get('div[role=dialog]:contains("Add Reviewer Suggestion")').find('button').contains('Save').click();
266-
cy.wait(3000);
267248
cy.get('div.reviewerSuggestionsListPanel').contains('Test Suggestion');
268249
cy.get('div.reviewerSuggestionsListPanel').contains('[email protected]');
250+
269251
cy.get('div.reviewerSuggestionsListPanel').find('button').contains('Edit').click();
270252
cy.get('.pkpFormField:contains("Given Name")').find('input[name*="-en"]').click().focused().clear().type('Testing');
271253
cy.get('.pkpFormField:contains("Family Name")').find('input[name*="-en"]').click().focused().clear().type('Suggestion 01');
272254
cy.get('div[role=dialog]:contains("Edit")').find('button').contains('Save').click();
273255
cy.wait(3000);
274256
cy.get('div.reviewerSuggestionsListPanel').contains('Testing Suggestion 01');
275-
276-
cy.get('button').contains('Add Reviewer Suggestion').should('be.visible').click();
277-
cy.get('.pkpFormField:contains("Given Name")').find('input[name*="-en"]').type('Test');
278-
cy.get('.pkpFormField:contains("Family Name")').find('input[name*="-en"]').type('Suggestion 02');
279-
cy.get('.pkpFormField:contains("Email")').find('input[name="email"]').type('[email protected]');
280-
cy.get('.pkpFormField:contains("Affiliation")').find('input[name*="-en"]').type('Test Affiliation');
281-
cy.setTinyMceContent('reviewerSuggestions-suggestionReason-control-en', 'Test suggestion reason');
282-
cy.get('div[role=dialog]:contains("Add Reviewer Suggestion")').find('button').contains('Save').click();
283-
cy.wait(3000);
284-
cy.get('#reviewerSuggestions-email-error').contains('The email has already been taken.');
285-
cy.get('div[role=dialog]:contains("Add Reviewer Suggestion")').find('button:contains("Close")').click();
286257
cy.get('div.reviewerSuggestionsListPanel').find('li.listPanel__item').should('have.length', 1);
258+
287259
cy.get('div.reviewerSuggestionsListPanel').find('button:contains("Delete")').click();
288260
cy.wait(200);
289261
cy.get('div[role=dialog]:contains("Delete Reviewer Suggestion")').find('button:contains("Cancel")').click();
@@ -428,7 +400,7 @@ describe('Data suite tests', function() {
428400
cy.enableReviewerSuggestion();
429401
});
430402

431-
it('Send submission to internal review stage with reviewer suggestion option set to unavailable', function () {
403+
it('Send submission to internal review stage where reviewer suggestion option is unavailable', function () {
432404
cy.findSubmissionAsEditor('dbarnes', null, 'Zedd');
433405
cy.clickDecision('Send to Internal Review');
434406
cy.recordDecisionSendToReview(
@@ -438,6 +410,11 @@ describe('Data suite tests', function() {
438410
);
439411
cy.isActiveStageTab('Internal Review');
440412
cy.get('h3:contains("Reviewers Suggested by Author")').should('not.exist');
413+
414+
// cancel the internal review round
415+
cy.get('button:contains("Cancel Review Round")').click();
416+
cy.wait(2000);
417+
cy.get('button:contains("Record Decision")').click();
441418
});
442419

443420
it('Send submission to external review stage with visible reviewer suggestion', function () {
@@ -461,15 +438,14 @@ describe('Data suite tests', function() {
461438

462439
it('Add non exist suggested reviewer from reviewer suggestion manager panel', function () {
463440
cy.findSubmissionAsEditor('dbarnes', null, 'Zedd');
464-
cy.wait(1000);
465441

466442
cy.get('[data-cy="reviewer-suggestion-manager"]')
467443
.find('button[aria-label="'+suggestions[0].fullname+' More Actions"]')
468444
.click({ force: true });
469445
cy.get('[data-cy="reviewer-suggestion-manager"]')
470446
.find('button:contains("Add Reviewer")')
471447
.click();
472-
cy.wait(300);
448+
cy.wait(2000);
473449

474450
cy.get('div[role=dialog]:contains("Add Reviewer")')
475451
.find('input[name="username"]')
@@ -479,7 +455,7 @@ describe('Data suite tests', function() {
479455
.find('button:contains("Add Reviewer")')
480456
.last()
481457
.click();
482-
cy.wait(3000);
458+
cy.wait(2000);
483459

484460
cy.get('[data-cy="reviewer-manager"]').contains(suggestions[0].fullname);
485461
cy.get('[data-cy="reviewer-suggestion-manager"]')
@@ -493,15 +469,15 @@ describe('Data suite tests', function() {
493469
cy.get('[data-cy="reviewer-manager"]')
494470
.find('button:contains("Add Reviewer")')
495471
.click();
496-
cy.wait(300);
472+
cy.wait(2000);
497473

498474
cy.get('div[role=dialog]:contains("Add Reviewer")')
499475
.find('div.reviewer-sugestions-list')
500476
.find('div.listPanel__itemTitle:contains("'+suggestions[1].fullname+'")')
501477
.parents('li.listPanel__item')
502478
.find('button:contains("Select Reviewer")')
503479
.click();
504-
cy.wait(300);
480+
cy.wait(2000);
505481

506482
cy.get('div[role=dialog]:contains("Add Reviewer")')
507483
.last()
@@ -512,7 +488,7 @@ describe('Data suite tests', function() {
512488
.find('button:contains("Add Reviewer")')
513489
.last()
514490
.click();
515-
cy.wait(3000);
491+
cy.wait(2000);
516492

517493
cy.get('div[role=dialog]:contains("Add Reviewer")')
518494
.last()
@@ -527,21 +503,20 @@ describe('Data suite tests', function() {
527503

528504
it('Add reviewer from suggestion with existed reviewer role from reviewer suggestion manager panel', function () {
529505
cy.findSubmissionAsEditor('dbarnes', null, 'Zedd');
530-
cy.wait(1000);
531506

532507
cy.get('[data-cy="reviewer-suggestion-manager"]')
533508
.find('button[aria-label="'+suggestions[3].fullname+' More Actions"]')
534509
.click({ force: true });
535510
cy.get('[data-cy="reviewer-suggestion-manager"]')
536511
.find('button:contains("Add Reviewer")')
537512
.click();
538-
cy.wait(300);
513+
cy.wait(2000);
539514

540515
cy.get('div[role=dialog]:contains("Add Reviewer")')
541516
.find('button:contains("Add Reviewer")')
542517
.last()
543518
.click();
544-
cy.wait(3000);
519+
cy.wait(2000);
545520

546521
cy.get('[data-cy="reviewer-manager"]').contains(suggestions[3].fullname);
547522
cy.get('[data-cy="reviewer-suggestion-manager"]')
@@ -555,21 +530,21 @@ describe('Data suite tests', function() {
555530
cy.get('[data-cy="reviewer-manager"]')
556531
.find('button:contains("Add Reviewer")')
557532
.click();
558-
cy.wait(300);
533+
cy.wait(2000);
559534

560535
cy.get('div[role=dialog]:contains("Add Reviewer")')
561536
.find('div.reviewer-sugestions-list')
562537
.find('div.listPanel__itemTitle:contains("'+suggestions[4].fullname+'")')
563538
.parents('li.listPanel__item')
564539
.find('button:contains("Select Reviewer")')
565540
.click();
566-
cy.wait(300);
541+
cy.wait(2000);
567542

568543
cy.get('div[role=dialog]:contains("Add Reviewer")')
569544
.last()
570545
.find('button:contains("Add Reviewer")')
571546
.click();
572-
cy.wait(3000);
547+
cy.wait(2000);
573548

574549
cy.get('[data-cy="reviewer-manager"]').contains(suggestions[4].fullname);
575550
cy.get('[data-cy="reviewer-suggestion-manager"]')
@@ -586,13 +561,13 @@ describe('Data suite tests', function() {
586561
cy.get('[data-cy="reviewer-suggestion-manager"]')
587562
.find('button:contains("Add Reviewer")')
588563
.click();
589-
cy.wait(300);
564+
cy.wait(2000);
590565

591566
cy.get('div[role=dialog]:contains("Add Reviewer")')
592567
.find('button:contains("Add Reviewer")')
593568
.last()
594569
.click();
595-
cy.wait(3000);
570+
cy.wait(2000);
596571

597572
cy.get('[data-cy="reviewer-manager"]').contains(suggestions[5].fullname);
598573
cy.get('[data-cy="reviewer-suggestion-manager"]')
@@ -606,22 +581,22 @@ describe('Data suite tests', function() {
606581
cy.get('[data-cy="reviewer-manager"]')
607582
.find('button:contains("Add Reviewer")')
608583
.click();
609-
cy.wait(300);
584+
cy.wait(2000);
610585

611586
cy.get('div[role=dialog]:contains("Add Reviewer")')
612587
.find('div.reviewer-sugestions-list')
613588
.find('div.listPanel__itemTitle:contains("'+suggestions[6].fullname+'")')
614589
.parents('li.listPanel__item')
615590
.find('button:contains("Select Reviewer")')
616591
.click();
617-
cy.wait(300);
592+
cy.wait(2000);
618593

619594
cy.get('div[role=dialog]:contains("Add Reviewer")')
620595
.last()
621596
.find('button:contains("Add Reviewer")')
622597
.last()
623598
.click();
624-
cy.wait(3000);
599+
cy.wait(2000);
625600

626601
cy.get('div[role=dialog]:contains("Add Reviewer")')
627602
.last()
@@ -640,12 +615,13 @@ describe('Data suite tests', function() {
640615
cy.get('[data-cy="reviewer-manager"]')
641616
.find('button:contains("Add Reviewer")')
642617
.click();
643-
cy.wait(300);
618+
cy.wait(2000);
644619

645620
cy.get('div[role=dialog]:contains("Add Reviewer")')
646621
.find('a:contains("Create New Reviewer")')
647622
.click();
648-
623+
cy.wait(2000);
624+
649625
cy.get('div[role=dialog]:contains("Add Reviewer")')
650626
.find('input[name="givenName[en]"]')
651627
.type(suggestions[2].givenName);
@@ -670,7 +646,7 @@ describe('Data suite tests', function() {
670646
.find('button:contains("Add Reviewer")')
671647
.last()
672648
.click();
673-
cy.wait(3000);
649+
cy.wait(2000);
674650

675651
cy.get('[data-cy="reviewer-manager"]').contains(suggestions[2].fullname);
676652
cy.get('[data-cy="reviewer-suggestion-manager"]')
@@ -684,12 +660,13 @@ describe('Data suite tests', function() {
684660
cy.get('[data-cy="reviewer-manager"]')
685661
.find('button:contains("Add Reviewer")')
686662
.click();
687-
cy.wait(300);
663+
cy.wait(2000);
688664

689665
cy.get('div[role=dialog]:contains("Add Reviewer")')
690666
.find('a:contains("Enroll Existing User")')
691667
.click();
692-
668+
cy.wait(2000);
669+
693670
cy.get('div[role=dialog]:contains("Add Reviewer")')
694671
.find('input[name="userId_input"]')
695672
.type(suggestions[7].fullname);
@@ -721,7 +698,7 @@ describe('Data suite tests', function() {
721698
cy.get('[data-cy="reviewer-manager"]')
722699
.find('button:contains("Add Reviewer")')
723700
.click();
724-
cy.wait(300);
701+
cy.wait(2000);
725702

726703
cy.get('div[role=dialog]:contains("Add Reviewer")')
727704
.find('div.listPanel--selectReviewer')
@@ -730,13 +707,13 @@ describe('Data suite tests', function() {
730707
.parents('li.listPanel__item')
731708
.find('button:contains("Select Reviewer")')
732709
.click();
733-
cy.wait(300);
710+
cy.wait(2000);
734711

735712
cy.get('div[role=dialog]:contains("Add Reviewer")')
736713
.last()
737714
.find('button:contains("Add Reviewer")')
738715
.click();
739-
cy.wait(3000);
716+
cy.wait(2000);
740717

741718
cy.get('[data-cy="reviewer-manager"]').contains(suggestions[8].fullname);
742719
cy.get('[data-cy="reviewer-suggestion-manager"]').should('not.exist');

0 commit comments

Comments
 (0)