Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI mode not compatible in fullscreen mode #11

Open
adambotfd opened this issue Dec 31, 2023 · 5 comments
Open

UI mode not compatible in fullscreen mode #11

adambotfd opened this issue Dec 31, 2023 · 5 comments

Comments

@adambotfd
Copy link

I have tried to install the custom ui multiple times but it isnt work.

image image image
@adambotfd
Copy link
Author

the theme only works when not in full screen 💀

@tovifun
Copy link
Owner

tovifun commented Jan 3, 2024

Sorry about that! I removed the borders because some users mentioned there were border when watching videos in full screen. I'll check if there's a way to improve that.🥲

@tovifun tovifun changed the title UI mode not working. UI mode not compatible in fullscreen mode Jan 12, 2024
@Dehelssey
Copy link

You could just have an alternative CSS file maybe ? Like we'd have one CSS with borders and one without and users could chose their flavor :)


For those interested, you could just add

#browser.mac.fullscreen:not(.mac-menubar-permanent):not(.mac-fullscreen-hover, .mac-fullscreen-hover-notch):not(.tabs-top) #main{
    padding: 10px 0;
}

to main_arc.css so you have bottom and top borders even in full window mode.
I also added this so inner window is rounded as well

#webview-container {
    border-radius: 8px;
    overflow: hidden;
}
image

@tovifun
Copy link
Owner

tovifun commented Feb 19, 2024

@Dehelssey Thanks for your suggestion(and code🥰)! I should have some time this week to roll out an update, and as you mentioned, I'll make different versions available for users to download.

@Dehelssey
Copy link

well i hope it's cleaner than mine because it only worked when tabs and panel were shown... otherwise you'd end up with a border on top and bottom but not on the sides anymore 😩

I've tweaked it a lot more since to fit my needs but i'm looking forward to your update :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants