Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_skip_develop_mode fails #3399

Closed
mcepl opened this issue Oct 8, 2024 · 1 comment
Closed

test_skip_develop_mode fails #3399

mcepl opened this issue Oct 8, 2024 · 1 comment

Comments

@mcepl
Copy link

mcepl commented Oct 8, 2024

Issue

Expected behaviour is that the tox’s own test suite passes without a problem. However, it is not so:

[   59s] =================================== FAILURES ===================================
[   59s] ____________________________ test_skip_develop_mode ____________________________
[   59s] [gw0] linux -- Python 3.10.15 /home/abuild/rpmbuild/BUILD/tox-4.14.2/testenv-3.10/bin/python
[   59s] 
[   59s] tox_project = <function init_fixture.<locals>._init at 0x7f3498f32680>
[   59s] demo_pkg_setuptools = PosixPath('/home/abuild/rpmbuild/BUILD/tox-4.14.2/tests/demo_pkg_setuptools')
[   59s] 
[   59s]     def test_skip_develop_mode(tox_project: ToxProjectCreator, demo_pkg_setuptools: Path) -> None:
[   59s]         proj = tox_project({"tox.ini": "[testenv]\npackage=wheel\n"})
[   59s]         execute_calls = proj.patch_execute(lambda r: 0 if "install" in r.run_id else None)
[   59s]         result = proj.run("--root", str(demo_pkg_setuptools), "--develop", "--workdir", str(proj.path / ".tox"))
[   59s]         result.assert_success()
[   59s]         calls = [(i[0][0].conf.name, i[0][3].run_id) for i in execute_calls.call_args_list]
[   59s]         expected = [
[   59s]             (".pkg", "install_requires"),
[   59s]             (".pkg", "_optional_hooks"),
[   59s]             (".pkg", "get_requires_for_build_editable"),
[   59s]             (".pkg", "install_requires_for_build_editable"),
[   59s]             (".pkg", "build_editable"),
[   59s]             ("py", "install_package"),
[   59s]         ]
[   59s] >       assert calls == expected
[   59s] E       AssertionError: assert [('.pkg', 'in...all_package')] == [('.pkg', 'in...all_package')]
[   59s] E         
[   59s] E         At index 3 diff: ('.pkg', 'build_editable') != ('.pkg', 'install_requires_for_build_editable')
[   59s] E         Right contains one more item: ('py', 'install_package')
[   59s] E         
[   59s] E         Full diff:
[   59s] E           [
[   59s] E               (...
[   59s] E         
[   59s] E         ...Full output truncated (24 lines hidden), use '-vv' to show
[   59s] 
[   59s] calls      = [('.pkg', 'install_requires'), ('.pkg', '_optional_hooks'), ('.pkg', 'get_requires_for_build_editable'), ('.pkg', 'build_editable'), ('py', 'install_package')]
[   59s] demo_pkg_setuptools = PosixPath('/home/abuild/rpmbuild/BUILD/tox-4.14.2/tests/demo_pkg_setuptools')
[   59s] execute_calls = <function _execute_call at 0x7f3498f33400>
[   59s] expected   = [('.pkg', 'install_requires'), ('.pkg', '_optional_hooks'), ('.pkg', 'get_requires_for_build_editable'), ('.pkg', 'install_requires_for_build_editable'), ('.pkg', 'build_editable'), ('py', 'install_package')]
[   59s] proj       = ToxProject(path=/tmp/pytest-of-abuild/pytest-0/popen-gw0/test_skip_develop_mode0/p) at 139863884582288
[   59s] result     = code: 0
[   59s] cmd: /home/abuild/rpmbuild/BUILD/tox-4.14.2/testenv-3.10/bin/python -m tox --root /home/abuild/rpmbuild/BUILD/...ge/1/demo_pkg_setuptools-1.2.3-0.editable-py3-none-any.whl
[   59s]   py: OK (0.43 seconds)
[   59s]   congratulations :) (0.45 seconds)
[   59s] 
[   59s] tox_project = <function init_fixture.<locals>._init at 0x7f3498f32680>
[   59s] 
[   59s] tests/session/cmd/test_sequential.py:306: AssertionError
[   59s] =========================== short test summary info ============================
[   59s] SKIPPED [1] tests/session/cmd/test_devenv.py:18: integration tests not run (no --run-integration flag)
[   59s] SKIPPED [1] tests/session/cmd/test_sequential.py:59: integration tests not run (no --run-integration flag)
[   59s] SKIPPED [1] tests/session/cmd/test_sequential.py:160: integration tests not run (no --run-integration flag)
[   59s] SKIPPED [1] tests/test_provision.py:127: integration tests not run (no --run-integration flag)
[   59s] SKIPPED [1] tests/test_provision.py:160: integration tests not run (no --run-integration flag)
[   59s] SKIPPED [2] tests/test_provision.py:194: integration tests not run (no --run-integration flag)
[   59s] SKIPPED [1] tests/test_provision.py:217: integration tests not run (no --run-integration flag)
[   59s] SKIPPED [2] tests/test_provision.py:226: integration tests not run (no --run-integration flag)
[   59s] SKIPPED [1] tests/tox_env/python/virtual_env/test_setuptools.py:19: integration tests not run (no --run-integration flag)
[   59s] FAILED tests/session/cmd/test_sequential.py::test_skip_develop_mode - Asserti...
[   59s] ================= 1 failed, 1678 passed, 11 skipped in 35.62s ==================

Environment

Provide at least (complete information including all packages used and steps taken to reproduce is recorded in the build log:

  • OS: openSUSE/Tumbleweed, rolling Linux distro, with Pythons 3.10.15, 3.11.10, and 3.12.7, tox 4.14.2 with the tarball from PyPI.
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Oct 9, 2024
https://build.opensuse.org/request/show/1206399
by user mcepl + anag+factory
- Skip test_skip_develop_mode (gh#tox-dev/tox#3399)
- Rename patches:
  - 0001-Make-use-of-devpi_process-optional.patch to optional_devpi_process.patch
  - 0002-skip-test-which-require-network-access.patch to mark-network-tests.patch
  which removes these two patches:
  - 0001-Make-use-of-devpi_process-optional.patch
  - 0002-skip-test-which-require-network-access.patch
@jugmac00
Copy link
Member

@mcepl Could you please clarify what command you ran to get this test failure?
Both CI is green and running the tests locally works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants