Fluent/Elemental: all translations but the last one saved are marked as modified

[wernerkrauss]

Module version(s) affected

5.2, 5.3

Description

When working with Elemental and BaseElement has FluentVersionedExtension applied, all translations of a block but the one saved last are marked as "Modified". That's cause Versioned::isLiveVersion() doesn't know about Fluent and having different Versions per Locale.

How to reproduce

• Create a project with Fluent and Elemental;
• Apply FluentVersionedExtension to BaseElement
• Create a bunch of locales
• Save a block and translate it to different Locales; publish the block in each locale.

Possible Solution

A possible solution would be to overwrite isLiveVersion() in FluentVersionedExtension:

    /**
     * Fixes a bug in Elemental/Fluent, where all translations but the last one saved are marked as modified,
     * cause Fluent saves a new Version per locale.
     * @return bool
     */
    public function isLiveVersion()
    {
        return !$this->getOwner()->stagesDifferInLocale();
    }

Additional Context

No response

Validations

• Check that there isn't already an issue that reports the same bug
• Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)