Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on silverstripe/installer:phpunit.xml.dist for testing #5

Open
sminnee opened this issue May 16, 2016 · 2 comments
Open

Comments

@sminnee
Copy link

sminnee commented May 16, 2016

See silverstripe/silverstripe-installer#119

phpunit.xml.dist is the test configuration provided for new sites. If cow needs to tests a number of modules before bundling the releases, it should rely on another configuration source.

This could be ~/.cow/phpunit.xml.dist,phpunit.xml.dist.cow, or something else (e.g. pre-release-build-test setting in composer.json), but we can't break project developer experience in order to support our build tooling.

@sminnee
Copy link
Author

sminnee commented May 16, 2016

A pre-release-build-test setting in composer.json would probably be my preferences. The scripts section should be useful for this.

@tractorcow
Copy link
Owner

That would be good, because different branches of installer could have custom release steps, so it fits that these live in the code base itself.

tractorcow pushed a commit that referenced this issue Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants