Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slice of struct #19

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix: slice of struct #19

merged 2 commits into from
Aug 29, 2024

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Aug 27, 2024

Description

This PR fix an issue with slice of struct.

Paerser was not able to fill correctly the following structs

type Foo struct {
	Values []string
	Bar []Bar
}

type Bar struct {
	Values []string
}

When reading the following configuration, paerser was producing incorrect struct.

Foo:
  Values:
    - 123
    - 456
  Bar:
    - Values:
        - 789
        - 014

Related to traefik/traefik#10996

Co-authored-by: Romain [email protected]

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit d116c5c into traefik:master Aug 29, 2024
4 checks passed
@mmatur mmatur deleted the fix/slice-struct branch August 29, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug/fix a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants