Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary additional newlines in extract generated interface wrappers #1641

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

kkoreilly
Copy link
Contributor

A side effect of #1281 is that it added unnecessary additional newlines in generated interface wrappers from the extract tool. This PR removes those newlines from the extract tool template and updates the generated code with that change.

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a minor change but ok. Thank you for your contribution.

@mvertes mvertes added enhancement New feature or request area/extract wrapper generation labels Jul 11, 2024
@mvertes mvertes added this to the v0.16.x milestone Jul 11, 2024
@mvertes
Copy link
Member

mvertes commented Jul 17, 2024

@mmatur could you please, or someone with admin permissions, check the CLA status?

It seems to be signed but is still not reported, blocking this PR and others to be merged?

Thanks!

@traefiker traefiker merged commit 77c1ce0 into traefik:master Jul 17, 2024
12 checks passed
@mmatur
Copy link
Member

mmatur commented Jul 17, 2024

@mmatur could you please, or someone with admin permissions, check the CLA status?

It seems to be signed but is still not reported, blocking this PR and others to be merged?

Thanks!

Hi @mvertes,

I fixed the issue regarding CLA, sorry about that.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extract wrapper generation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants