interp: fix a missing implicit type conversion for binary expression #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing binary operator expressions, make sure that implicit type conversions for untyped expressions are performed. It involves walking the sub-expression subtree at post-processing of binary expressions. Fixes traefik#1653.
mpl
reviewed
Jul 29, 2024
Comment on lines
+2310
to
+2318
| nod.Walk(func(n *node) bool { | ||
| if n == nod || (n.kind != binaryExpr && n.kind != parenExpr) || !n.typ.untyped { | ||
| return true | ||
| } | ||
| n.typ = nod.typ | ||
| if n.findex >= 0 { | ||
| sc.types[n.findex] = nod.typ.frameType() | ||
| } | ||
| return true |
There was a problem hiding this comment.
Does it ever implicitly return false?
There was a problem hiding this comment.
A callback returning false terminates the tree walk. In our case, we just want to skip the node, but continue to process the rest of the expression subtree, looking for untyped expressions, so the callback always returns true.
mpl
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing binary operator expressions, make sure that implicit type conversions for untyped expressions are performed. It involves walking the sub-expression subtree at post-processing of binary expressions.
Fixes #1653.