Default metrics are gone when adding a custom instrumentation

[stephen-lazarionok]

Once I add my custom instrumentation the default metrics are gone..

def my_custom_http_instrumentation(cfg) -> Callable[[Info], None]:
    cntr = Counter(
        "my_http_reqs_total",
        "Number of request accepted.",
        [
            "tenant",
            "tenant_version",
            "method",
            "handler",
            "api_user",
            "response_code",
        ],
    )

    def instrumentation(info: Info) -> None:
        ...
        # implementation
       ...

    return instrumentation


instrumentator = Instrumentator(
    should_group_status_codes=False,
    should_ignore_untemplated=True,
    should_respect_env_var=True,
    should_instrument_requests_inprogress=True,
    excluded_handlers=["/metrics"],
    env_var_name="ENABLE_METRICS",
    inprogress_name="inprogress",
    inprogress_labels=True,
)

instrumentator.add(my_custom_http_instrumentation(my_config))
instrumentator.instrument(app)
instrumentator.expose(app, include_in_schema=False, should_gzip=True)

[dasshit]

prometheus-fastapi-instrumentator/src/prometheus_fastapi_instrumentator/middleware.py

Line 85 in b645ccb

if instrumentations:

[dasshit]

Following code will resolve your issue

from prometheus_fastapi_instrumentator import metrics


def my_custom_http_instrumentation(cfg) -> Callable[[Info], None]:
    cntr = Counter(
        "my_http_reqs_total",
        "Number of request accepted.",
        [
            "tenant",
            "tenant_version",
            "method",
            "handler",
            "api_user",
            "response_code",
        ],
    )

    def instrumentation(info: Info) -> None:
        ...
        # implementation
       ...

    return instrumentation


instrumentator = Instrumentator(
    should_group_status_codes=False,
    should_ignore_untemplated=True,
    should_respect_env_var=True,
    should_instrument_requests_inprogress=True,
    excluded_handlers=["/metrics"],
    env_var_name="ENABLE_METRICS",
    inprogress_name="inprogress",
    inprogress_labels=True,
)

instrumentator.add(my_custom_http_instrumentation(my_config))
instrumentator.add(metrics.default())
instrumentator.instrument(app)
instrumentator.expose(app, include_in_schema=False, should_gzip=True)

[lucasalvarezlacasa]

Thank you so much, I was experiencing this same issue today!.

[kkivan]

for anyone trying to understand the diff you just need to add
instrumentator.add(metrics.default())
before calling intrument