merge B-21348

transcom · Feb 13, 2025 · 847a8b9 · 847a8b9
2 parents 1ee2e63 + 7261c53
commit 847a8b9
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 53 deletions.
diff --git a/pkg/gen/ghcapi/embedded_spec.go b/pkg/gen/ghcapi/embedded_spec.go
diff --git a/pkg/gen/ghcapi/ghcoperations/queues/save_bulk_assignment_data_responses.go b/pkg/gen/ghcapi/ghcoperations/queues/save_bulk_assignment_data_responses.go
diff --git a/pkg/handlers/ghcapi/queues.go b/pkg/handlers/ghcapi/queues.go
@@ -876,7 +876,7 @@ func (h SaveBulkAssignmentDataHandler) Handle(
 				return queues.NewGetServicesCounselingQueueInternalServerError(), err
 			}
 
-			return queues.NewSaveBulkAssignmentDataOK(), nil
+			return queues.NewSaveBulkAssignmentDataNoContent(), nil
 		})
 }
 

diff --git a/pkg/handlers/ghcapi/queues_test.go b/pkg/handlers/ghcapi/queues_test.go
@@ -2377,7 +2377,7 @@ func (suite *HandlerSuite) TestSaveBulkAssignmentDataHandler() {
 		}
 		response := handler.Handle(params)
 		suite.IsNotErrResponse(response)
-		suite.IsType(&queues.SaveBulkAssignmentDataOK{}, response)
+		suite.IsType(&queues.SaveBulkAssignmentDataNoContent{}, response)
 	})
 }
 

diff --git a/pkg/services/move/move_fetcher.go b/pkg/services/move/move_fetcher.go
@@ -299,7 +299,7 @@ func (f moveFetcherBulkAssignment) FetchMovesForBulkAssignmentPaymentRequest(app
 	sqlQuery := `
 		SELECT
 			moves.id,
-			COALESCE(MIN(payment_requests.requested_at), '0001-01-01') AS earliest_date
+			MIN(payment_requests.requested_at) AS earliest_date
 		FROM moves
 		INNER JOIN orders ON orders.id = moves.orders_id
 		INNER JOIN service_members ON orders.service_member_id = service_members.id

diff --git a/swagger-def/ghc.yaml b/swagger-def/ghc.yaml
@@ -3613,10 +3613,8 @@ paths:
           schema:
             $ref: '#/definitions/BulkAssignmentSavePayload'
       responses:
-        '200':
-          description: Successfully returned bulk assignment data
-          schema:
-            $ref: '#/definitions/BulkAssignmentData'
+        '204':
+          description: assigned
         '401':
           $ref: '#/responses/PermissionDenied'
         '404':

diff --git a/swagger/ghc.yaml b/swagger/ghc.yaml
@@ -3742,10 +3742,8 @@ paths:
           schema:
             $ref: '#/definitions/BulkAssignmentSavePayload'
       responses:
-        '200':
-          description: Successfully returned bulk assignment data
-          schema:
-            $ref: '#/definitions/BulkAssignmentData'
+        '204':
+          description: assigned
         '401':
           $ref: '#/responses/PermissionDenied'
         '404':
-Original file line number
+Diff line change
@@ Expand Up / @@ -876,7 +876,7 @@ func (h SaveBulkAssignmentDataHandler) Handle( @@
     				return queues.NewGetServicesCounselingQueueInternalServerError(), err
     			}
-    			return queues.NewSaveBulkAssignmentDataOK(), nil
+    			return queues.NewSaveBulkAssignmentDataNoContent(), nil
     		})
     }
@@ Expand Down @@