Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 256 with layout.TileWidth/layout.EntryBundleWidth #409

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

roger2hk
Copy link
Contributor

@roger2hk roger2hk commented Dec 9, 2024

No description provided.

Copy link
Collaborator

@AlCutter AlCutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks @roger2hk for doing this!

LGTM, just with a suggestion to revert the lines in here which are related to batching & dedup.

cmd/conformance/posix/main.go Outdated Show resolved Hide resolved
cmd/conformance/posix/main.go Outdated Show resolved Hide resolved
log.go Outdated Show resolved Hide resolved
@roger2hk
Copy link
Contributor Author

Nice one, thanks @roger2hk for doing this!

LGTM, just with a suggestion to revert the lines in here which are related to batching & dedup.

Reverted those changes related to batching & dedup in all storage conformances.

@roger2hk roger2hk merged commit 246624f into transparency-dev:main Dec 10, 2024
15 checks passed
@roger2hk roger2hk deleted the replace-256 branch December 10, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants