Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've closed #3 by mistake but this time I nailed it, I fixed the precision issue, you were right @trentpiercy .
so I'm drawing strokes inside of the rect using
oRect.deflate(rectPaint.strokeWidth/2)
it's quite clean.having Paints as parameters instead of colors, allows for customizing of the line size, color and style within one property, pretty awesome.
also added
candleSpacing
default values are left as default (green stroke, red fill, volume same)