Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading results after budget fails #10

Closed
shortcircuit3 opened this issue Nov 11, 2019 · 6 comments
Closed

Uploading results after budget fails #10

shortcircuit3 opened this issue Nov 11, 2019 · 6 comments
Labels
bug Something isn't working

Comments

@shortcircuit3
Copy link

image

Is this correct that the upload does not proceed if the budget fails? In your examples it looks like the budget uploads.

My workflow

name: CI

on: push

jobs:
  build:

    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v1

    - name: Lighthouse CI Action
      uses: treosh/lighthouse-ci-action@v1
      with:
        urls: 'http://milesalex.github.io/gatsby'
        budgetPath: .github/workflows/budget.json

    - name: Upload results
      uses: actions/upload-artifact@master
      with:
        name: lighthouse-results
        path: './results'
@shortcircuit3
Copy link
Author

@alekseykulikov
Copy link
Member

Hey @milesalex! Thank you for the report.
I agree it's a bug, that the action fails and you can't debug the results.
Have you tried continue-on-error option?

Also, have you taken a look at today's @v2 release? It has temporaryPublicStorage: true option and supports much more advanced assertions format.

@alekseykulikov alekseykulikov added the bug Something isn't working label Nov 11, 2019
@shortcircuit3
Copy link
Author

I'll check these out. Thank you for the reply!

@alekseykulikov
Copy link
Member

Current solution is #10 (comment).
At #2 we discuss our options and will be happy to hear your input.

@shortcircuit3
Copy link
Author

are the units fixed in v2?

@alekseykulikov
Copy link
Member

if you refer to #13 than yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants