Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support linking against system bzip2 without pkg-config #104

Open
mgorny opened this issue Sep 6, 2024 · 0 comments
Open

Please support linking against system bzip2 without pkg-config #104

mgorny opened this issue Sep 6, 2024 · 0 comments

Comments

@mgorny
Copy link

mgorny commented Sep 6, 2024

The following logic:

https://github.com/alexcrichton/bzip2-rs/blob/3032f3790742bffda521e54d14429f459e078eba/bzip2-sys/build.rs#L15-L24

makes it possible to use system bzip2 library only if it does supply a pkg-config file. However, as of today bzip2 does not install a pkg-config file. As such, this is either dead code or entirely reliant on custom third-party patching.

Could you please add a fallback logic that could be used to link against vanilla bzip2 install? For example, blosc2-sys does that via supporting BLOSC2_INSTALL_PREFIX envvar:

https://github.com/milesgranger/blosc2-rs/blob/7963c3c1c0cc4276d158df5d8bde87430985737c/blosc2-sys/build.rs#L72-L79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant