Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bzip2::Compression type does not allow arbitrary values from 1-9 #25

Open
mdsteele opened this issue Mar 10, 2018 · 5 comments
Open

bzip2::Compression type does not allow arbitrary values from 1-9 #25

mdsteele opened this issue Mar 10, 2018 · 5 comments

Comments

@mdsteele
Copy link

The bzip2::Compression type only allows the options Fastest (1), Default (6), or Best (9). There seems to be no way to specify a compression level of, say, 4.

Perhaps it would be better to make bzip2::Compression work like flate2::Compression (which does allow arbitrary numbers), since the two crates already have very similar APIs otherwise?
@alexcrichton
Copy link
Collaborator

Indeed! They actually started the same way and I haven't gotten around to updating this version :(

I'll try to sync the two APIs this week and hopefully push out a 1.0 as well!

@dragonmaus
Copy link
Contributor

Has there been any progress on this issue?

@alexcrichton
Copy link
Collaborator

Unfortunately no, but some assistance in implementing would be appreciated!

@dragonmaus
Copy link
Contributor

Opened #37.

@d-e-s-o
Copy link

d-e-s-o commented Feb 2, 2022

It appears we should be able to close this issue given that #37 got merged (and, in fact, released), no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mdsteele @alexcrichton @dragonmaus @d-e-s-o