Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write::BzDecoder: Fix infinite loop on drop when no data is read or written #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chenxiaolong
Copy link

If writes to the BzDecoder end before it has been fed the entire stream and the output buffer has already been flushed to the wrapped writer, then the Drop implementation will loop forever. On drop, try_finish() is called, which repeatedly tries to write() until BZ_STREAM_END is returned or an error occurs, but neither scenario happens if there's no input nor output data to process.

This commit makes try_finish() return an UnexpectedEof error in this scenario.


(Also, really happy to see this library found a new maintainer!)

…ritten

If writes to the BzDecoder end before it has been fed the entire stream
and the output buffer has already been flushed to the wrapped writer,
then the Drop implementation will loop forever. On drop, try_finish() is
called, which repeatedly tries to write() until BZ_STREAM_END is
returned or an error occurs, but neither scenario happens if there's no
input nor output data to process.

This commit makes try_finish() return an UnexpectedEof error in this
scenario.

Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant