Remove invalid default from

trinodb · Oct 3, 2024 · 1fb52c4 · 1fb52c4
1 parent 36a4833
commit 1fb52c4
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/charts/trino/README.md b/charts/trino/README.md
@@ -39,7 +39,14 @@ Fast distributed SQL query engine for big data analytics that helps you explore
 
   When true, only the content in `repository` is used as image reference
 * `image.pullPolicy` - string, default: `"IfNotPresent"`
-* `imagePullSecrets[0].name` - string, default: `"registry-credentials"`
+* `imagePullSecrets` - object, default: `{}`  
+
+  An optional list of references to secrets in the same namespace to use for pulling images.
+  Example:
+  ```yaml
+  imagePullSecrets:
+    - name: registry-credentials
+  ```
 * `server.workers` - int, default: `2`
 * `server.node.environment` - string, default: `"production"`
 * `server.node.dataDir` - string, default: `"/data/trino"`

diff --git a/charts/trino/templates/deployment-coordinator.yaml b/charts/trino/templates/deployment-coordinator.yaml
@@ -111,8 +111,10 @@ spec:
       initContainers:
       {{- tpl (toYaml .Values.initContainers.coordinator) . | nindent 6 }}
       {{- end }}
+      {{- if .Values.imagePullSecrets}}
       imagePullSecrets:
         {{- toYaml .Values.imagePullSecrets | nindent 8 }}
+      {{- end }}
       terminationGracePeriodSeconds: {{ .Values.coordinator.terminationGracePeriodSeconds }}
       containers:
         - name: {{ .Chart.Name }}-coordinator

diff --git a/charts/trino/values.yaml b/charts/trino/values.yaml
@@ -28,8 +28,14 @@ image:
   useRepositoryAsSoleImageReference: false
   pullPolicy: IfNotPresent
 
-imagePullSecrets:
-  - name: registry-credentials
+# -- An optional list of references to secrets in the same namespace to use for pulling images.
+# @raw
+# Example:
+# ```yaml
+# imagePullSecrets:
+#   - name: registry-credentials
+# ```
+imagePullSecrets: {}
 
 server:
   workers: 2