From b7dcef9f62d6ead5a79c5b45173195c575810bc9 Mon Sep 17 00:00:00 2001
From: maverick_p <jlchen@cs.toronto.edu>
Date: Wed, 14 Aug 2024 22:45:37 -0400
Subject: [PATCH] Add comments for Additional Exchange Manager Properties

---
 charts/trino/README.md   | 11 ++++++++++-
 charts/trino/values.yaml | 11 ++++++++++-
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/charts/trino/README.md b/charts/trino/README.md
index e55fe898..b7b003a5 100644
--- a/charts/trino/README.md
+++ b/charts/trino/README.md
@@ -222,7 +222,16 @@ Fast distributed SQL query engine for big data analytics that helps you explore
   ```yaml
    - io.airlift=DEBUG
   ```
-* `additionalExchangeManagerProperties` - list, default: `[]`
+* `additionalExchangeManagerProperties` - list, default: `[]`  
+
+  [Exchange manager properties](https://trino.io/docs/current/admin/fault-tolerant-execution.html#exchange-manager).
+  Example:
+  ```yaml
+   - exchange.s3.region=object-store-region
+   - exchange.s3.endpoint=your-object-store-endpoint
+   - exchange.s3.aws-access-key=your-access-key
+   - exchange.s3.aws-secret-key=your-secret-key
+  ```
 * `eventListenerProperties` - list, default: `[]`  
 
   [Event listener](https://trino.io/docs/current/develop/event-listener.html#event-listener) properties. To configure multiple event listeners, add them in `coordinator.additionalConfigFiles` and `worker.additionalConfigFiles`, and set the `event-listener.config-files` property in `additionalConfigProperties` to their locations.
diff --git a/charts/trino/values.yaml b/charts/trino/values.yaml
index 60854f84..f792a4af 100644
--- a/charts/trino/values.yaml
+++ b/charts/trino/values.yaml
@@ -208,7 +208,6 @@ resourceGroups: {}
 #      }
 # ```
 
-
 additionalNodeProperties: []
 # additionalNodeProperties -- [Additional node
 # properties](https://trino.io/docs/current/installation/deployment.html#log-levels).
@@ -238,6 +237,16 @@ additionalLogProperties: []
 # ```
 
 additionalExchangeManagerProperties: []
+# additionalExchangeManagerProperties -- [Exchange manager
+# properties](https://trino.io/docs/current/admin/fault-tolerant-execution.html#exchange-manager).
+# @raw
+# Example:
+# ```yaml
+#  - exchange.s3.region=object-store-region
+#  - exchange.s3.endpoint=your-object-store-endpoint
+#  - exchange.s3.aws-access-key=your-access-key
+#  - exchange.s3.aws-secret-key=your-secret-key
+# ```
 
 eventListenerProperties: []
 # eventListenerProperties -- [Event