From bf91a7da60d5984c50bebb32eac004ea237510d6 Mon Sep 17 00:00:00 2001
From: yassan <yassan0627@gmail.com>
Date: Mon, 4 Nov 2024 03:59:44 +0900
Subject: [PATCH] Fixes for CI feedback

---
 charts/trino/README.md | 130 +++++++++++++++++++++++------------------
 1 file changed, 72 insertions(+), 58 deletions(-)

diff --git a/charts/trino/README.md b/charts/trino/README.md
index 6bc07bda..68452a33 100644
--- a/charts/trino/README.md
+++ b/charts/trino/README.md
@@ -1,6 +1,6 @@
 # trino
 
-![Version: 0.33.0](https://img.shields.io/badge/Version-0.33.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 464](https://img.shields.io/badge/AppVersion-464-informational?style=flat-square)
+![Version: 0.34.0](https://img.shields.io/badge/Version-0.34.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 464](https://img.shields.io/badge/AppVersion-464-informational?style=flat-square)
 
 Fast distributed SQL query engine for big data analytics that helps you explore your data universe
 
@@ -175,65 +175,79 @@ Fast distributed SQL query engine for big data analytics that helps you explore
   ```
 * `resourceGroups` - object, default: `{}`  
 
-  Resource groups file is mounted to /etc/trino/resource-groups/resource-groups.json
-  Example:
+  [Resource groups control](https://trino.io/docs/current/admin/resource-groups.html)
+  Set the type property to either:
+  * `configmap`, and provide the Resource groups file contents in `resourceGroupsConfig`,
+  * `properties`, and provide configuration properties in `properties`.
+  Properties example:
+  ```yaml
+   type: properties
+   properties: |
+     resource-groups.configuration-manager=db
+     resource-groups.config-db-url=jdbc:mysql://localhost:3306/resource_groups
+     resource-groups.config-db-user=username
+     resource-groups.config-db-password=password
+  ```
+  Config map example:
   ```yaml
+   type: configmap
+   # Resource groups file is mounted to /etc/trino/resource-groups/resource-groups.json
    resourceGroupsConfig: |-
-       {
-         "rootGroups": [
-           {
-             "name": "global",
-             "softMemoryLimit": "80%",
-             "hardConcurrencyLimit": 100,
-             "maxQueued": 100,
-             "schedulingPolicy": "fair",
-             "jmxExport": true,
-             "subGroups": [
-               {
-                 "name": "admin",
-                 "softMemoryLimit": "30%",
-                 "hardConcurrencyLimit": 20,
-                 "maxQueued": 10
-               },
-               {
-                 "name": "finance_human_resources",
-                 "softMemoryLimit": "20%",
-                 "hardConcurrencyLimit": 15,
-                 "maxQueued": 10
-               },
-               {
-                 "name": "general",
-                 "softMemoryLimit": "30%",
-                 "hardConcurrencyLimit": 20,
-                 "maxQueued": 10
-               },
-               {
-                 "name": "readonly",
-                 "softMemoryLimit": "10%",
-                 "hardConcurrencyLimit": 5,
-                 "maxQueued": 5
-               }
-             ]
-           }
-         ],
-         "selectors": [
-           {
-             "user": "admin",
-             "group": "global.admin"
-           },
-           {
-             "group": "finance|human_resources",
-             "group": "global.finance_human_resources"
-           },
-           {
-             "user": "alice",
-             "group": "global.readonly"
-           },
-           {
-             "group": "global.general"
-           }
-         ]
-       }
+     {
+       "rootGroups": [
+         {
+           "name": "global",
+           "softMemoryLimit": "80%",
+           "hardConcurrencyLimit": 100,
+           "maxQueued": 100,
+           "schedulingPolicy": "fair",
+           "jmxExport": true,
+           "subGroups": [
+             {
+               "name": "admin",
+               "softMemoryLimit": "30%",
+               "hardConcurrencyLimit": 20,
+               "maxQueued": 10
+             },
+             {
+               "name": "finance_human_resources",
+               "softMemoryLimit": "20%",
+               "hardConcurrencyLimit": 15,
+               "maxQueued": 10
+             },
+             {
+               "name": "general",
+               "softMemoryLimit": "30%",
+               "hardConcurrencyLimit": 20,
+               "maxQueued": 10
+             },
+             {
+               "name": "readonly",
+               "softMemoryLimit": "10%",
+               "hardConcurrencyLimit": 5,
+               "maxQueued": 5
+             }
+           ]
+         }
+       ],
+       "selectors": [
+         {
+           "user": "admin",
+           "group": "global.admin"
+         },
+         {
+           "group": "finance|human_resources",
+           "group": "global.finance_human_resources"
+         },
+         {
+           "user": "alice",
+           "group": "global.readonly"
+         },
+         {
+           "group": "global.general"
+         }
+       ]
+     }
   ```
 * `additionalNodeProperties` - list, default: `[]`