Skip to content
This repository has been archived by the owner on Jan 21, 2023. It is now read-only.

Cover calculation is extremely slow for large tokens with many small tokens on top #306

Open
Zamrod opened this issue Aug 14, 2022 · 2 comments
Labels
enhancement improvement to existing feature help wanted Extra attention is needed
Milestone

Comments

@Zamrod
Copy link

Zamrod commented Aug 14, 2022

If you create large vehicles and put a bunch of people on them and then have weapons on the vehicles then when you set MIDI QoL's optional setting for determining if Walls Block attacks to dnd5e helpers + AC and dnd5e helpers is set to 4 points as its method then the attack roll will take about 30-45 seconds to resolve and lock up Foundry. If you change Midi QoL to just "center check" it resolves immediately.

fvtt-Scene-wildspace.txt

@trioderegion
Copy link
Owner

If Helpers is set to centerpoint only check (assuming the midi option "center check" you mentioned is a different thing), do you also get a similar speed up?

Just trying to triage -- this issue doesnt surprise me, but I havent seen it myself. I'll look into it when updating for v10. I can't promise anything, as the core logic is a nested loop, but maybe we can find some easy wins.

@trioderegion trioderegion added enhancement improvement to existing feature help wanted Extra attention is needed labels Aug 14, 2022
@trioderegion trioderegion added this to the 4.3.0 milestone Aug 14, 2022
@Zamrod
Copy link
Author

Zamrod commented Aug 14, 2022

If Helpers is set to centerpoint only check (assuming the midi option "center check" you mentioned is a different thing), do you also get a similar speed up?

It speeds up quite a bit when I do that. It still locks up for about a second though

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement improvement to existing feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants