-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule Book PDF & HTML need review / update #347
Comments
Hi, I am trying to do my first PR and I was wondering if I could take a crack at fixing the embedded links. Currently its not clickable and in a bit of a mess. The Table of Contents links are broken for some links too, for example The Units and Units Used in “Big World : 1942”. If you let me know how I can update the credits, I can do that too. |
@Kwill3 The re-formatting of the guide I don't think was ever completed. It could use some better markdown/html formatting overall. Feel free to go to town! I think the 'credits' portion would take some work to trace the history. It's interesting history, but maybe this is not the right place for it. It might be better to strike the section entirely. |
I've submitted a PR with the credits removed. Would centering the pngs constitute as better formatting of the page? |
have no clue of how to manage this |
@Esme6969 What exactly do you need help with? The Rulebook in question can be found here: https://github.com/triplea-game/triplea-game.github.io/blob/master/user-guide/rule-book/rule-book.md |
So probably should get familiar with what this software does. Just making a comment. |
This leaves only the HTML versions. It is therefore less to 'fix' (there is still work needed). Of biggest note, anything that was out of sync between PDF and HTML, is no longer an issue (the HTML version would be the most up to date). Helps address part of #347, reduces the size of the problem noted in #347.
PR link above removes the PDF versions of the rule books. That advances us a little bit closer to a solution since there is only thing that needs updating.. But, we still need a pretty solid effort from someone (#volunteersNeeded) to still actually update the contents in detail & fix the formatting. |
This leaves only the HTML versions. It is therefore less to 'fix' (there is still work needed). Of biggest note, anything that was out of sync between PDF and HTML, is no longer an issue (the HTML version would be the most up to date). Helps address part of #347, reduces the size of the problem noted in #347.
Both immediately (see embedded links to sourceforge.net) below, and prior to the release of 2.0 (screenshots, verbiage/instructions, etc.).
Also credits at end are out of date:
The text was updated successfully, but these errors were encountered: