Europe Improved ready to be added

[VictoryFirst2]

Hi, I have made improvements to the module for Axis & Allies: Europe (1999), called "Europe - Beta". Almost every single bug has been fixed and new features have been added to make as many things as possible governed by the engine.

Here is my repository: https://github.com/VictoryFirst2/europe_improved

The original module can be found in this repository: https://github.com/triplea-maps/europe

[beelee1]

Hi Victory

You have this as a Issue. You need to make a Pull Request to the repo you want to change. And then make a PR for it.

Issues are for bugs/user problems and probably other stuff :)

[VictoryFirst2]

Oh, it said in this guide I needed to create an issue xD: https://docs.google.com/document/d/1FfF7N0srp9QG0_if5D-c1d1Aa1QTttdhxgm1GBh3pI4/edit?tab=t.0

[VictoryFirst2]

So how do I create a pull request? It should be a separate module, not replace an existing module.

[beelee1]

yea so go to the repo and fork it

then make your changes and make a PR
I think lol

[beelee1]

go to our repo and make a minor change. Change the xml by 1 number

Should be a big green buttuon show up hit that

[beelee1]

there might be access stuff going on.

You got access to EXP so try a minor one there

[beelee1]

Oh ? You want a new game basically then. Gotta make a repo from scratch and all the stuff to it then do a yaml PR

[VictoryFirst2]

Ah so I just need to edit the yaml? But shouldn't my repo be added to triplea maps?

[beelee1]

Oh yea that link is outdated

[beelee1]

hmm I struggle with this. Lets @RogerCooper if he can help

[RogerCooper]

I will try adding the game in.

[RogerCooper]

I posted into github under https://github.com/triplea-maps/europe_improved. I will add to triplea_maps.yaml tomorrow.

[VictoryFirst2]

@RogerCooper Great job! And if I would want to make a change to my module, can I just do that using Add Files? I just realized it might be a good idea to put a screenshot of the game board in the game notes. EDIT: Never mind, I don't think it's a good idea.

[VictoryFirst2]

And also can the version number be 1.8? I see other maps have integers as version numbers (1, 2, 3, etc.) but mine is 1.8 😂 I hope that won't mess anything up?

[VictoryFirst2]

@RogerCooper OK so a picture of the game board in the game notes is not really necessary but I realized that the preview.png and the image in the description are still from the old map. They need to be replaced by ones of the new map but for that it says I need push access.

[VictoryFirst2]

In the new map the Middle Eastern territories are yellow instead of tan so that might cause confusion :)

[VictoryFirst2]

OK I figured it out. I created a fork but I was apparently still modifying the original module. I made changes to the images and also updated the description. It is now definitely ready for upload.

@beelee1 So I have to create a PR now?

[beelee1]

@VictoryFirst2 I would go to the repo Roger created and ask him for write access. Then you can make a test branch and add your new changes. Do the PR. Delete branch.

Then another PR is required for the map yaml. The first one takes a little setup time. After that, you just change the version number. Yaml versions must use whole numbers.

Look at existing ones. You might want Roger to do the initial one. Also the description image can be changed in the description folder and I think you might need to do something else. I forget. I still need to change EXP's

Edit
To add images to the Game Notes, add the png to doc/images, then type it in to the notes. I forget what you have to type. Look at EXP

[frigoref]

@VictoryFirst2 I just skimmed through this, but it seemed that initially you had problems understanding what needs to be done when having your own map repository in order to contribute to triplea.
Could you please recheck How to contribute to Triplea for Map Makers and the mentioned links for what is missing.
It would be very helpful if you could you your recent experience to improve the information provided on these sites. Best would be, when you could create another PR which can be easily done per md-file by simply pressing the button (edit).

@beelee1 If you have understood what was missing, feel free to contribute yourself with a PR.

[VictoryFirst2]

@frigoref Yeah I simply had some trouble navigating GitHub. I didn't know the guides you mentioned existed, I used this one: https://docs.google.com/document/d/1FfF7N0srp9QG0_if5D-c1d1Aa1QTttdhxgm1GBh3pI4/edit?tab=t.0.

I think the guides on GitHub are fine, if I knew they were there then I think I wouldn't have had any problems.

The only thing I don't understand is that the preview.png of my map doesn't show

Even though I have a preview.png in my repo. Could you help me with this?

[frigoref]

@VictoryFirst2 This is due to the wrong link in the triplea_maps.yaml file (link)

You might want to correct this :)

[frigoref]

@frigoref Yeah I simply had some trouble navigating GitHub. I didn't know the guides you mentioned existed, I used this one: https://docs.google.com/document/d/1FfF7N0srp9QG0_if5D-c1d1Aa1QTttdhxgm1GBh3pI4/edit?tab=t.0.

I think the guides on GitHub are fine, if I knew they were there then I think I wouldn't have had any problems.

Do you think there is anything in this Google Docs file that is missing / better? If so, we should think to incorporate this in the triplea documentation and get rid of this separately stored documentation.

[VictoryFirst2]

@frigoref Ah, so like this? https://github.com/triplea-maps/europe_improved/blob/master/preview.png

Yeah I found the Google Doc very good, it explained how I can upload my map to GitHub with the same file structure as other maps using Git GUI. However for Step 6, it says you need to open an issue to request your map being uploaded to triplea-maps but @beelee1 said that has changed. And for Step 7, I would include some pictures that show the buttons for "fork" and "pull_request", that would guide people more to the right direction I think.

Oh yeah if that link thingy on top is correct, then perhaps make a note of that in the documentation as all the other links have raw.githubusercontent in them and I don't understand why.

That's all, I think the guide explains everything very well. I was just afraid to do something wrong 😂

Honestly I think some video documentation about this would be very helpful. Now I understand how it works I'd be happy to make some videos someday explaining how to make maps, modify existing maps, and upload your map to triplea.

[frigoref]

@VictoryFirst2 The link is correct.
Would be great of you could provide a PR for that.

Concerning the documentation and video: Would be great if you could provide another PR on that matter. Everything that helps is worth having it in the triplea docs folder to grow it to a good (and the only place) of place reference to go to.

[beelee1]

Hi @VictoryFirst2

Can this be closed now ?

[VictoryFirst2]

@beelee1 Yeah frigoref asked me to create a PR for the google document but I don't know how to do that because that's on the TripleA forum. The guide for uploading maps to github.

[frigoref]

@VictoryFirst2: My idea was to move everything about the documentation into github (folder docs). You can copy and modify the guide you have found in the TripleA forum and you can also create new md-files. The main goal is to have one place for all documentation.
@beelee1: I would like to keep this ticket open until we have also adjusted the user documentation related to it.