Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark theme #4

Open
AdamSiekierski opened this issue Oct 28, 2020 · 3 comments
Open

Dark theme #4

AdamSiekierski opened this issue Oct 28, 2020 · 3 comments
Assignees
@datejer
Labels
enhancement New feature or request

Comments

@AdamSiekierski
Copy link
Member

AdamSiekierski commented Oct 28, 2020 •
edited
Loading

When refactor to styled-components (#3) will be complete, it would be nice if we implement dark theme, using styled-components built in theming support.
@AdamSiekierski AdamSiekierski added the enhancement New feature or request label Oct 28, 2020
@AdamSiekierski
Copy link
Member Author

That should be our main focus now. Does anyone want to do that? The tasks are:

  • Modify our current StyledTheme, to have two versions - light and dark
  • Create a button which sets the theme (according to system default, but also allows to save the state in localStorage
  • Connect them both via Context or just simply using state (we'll check what would be better, idk how deep in components tree would be the button)

@datejer @AleksanderSkubala would you like to create that feature?

@AdamSiekierski AdamSiekierski removed their assignment Nov 4, 2020
@datejer
Copy link
Member

datejer commented Nov 4, 2020

I can take this one :D

@AdamSiekierski
Copy link
Member Author

Epic :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datejer datejer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AdamSiekierski @AleksanderSkubala @datejer