Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The duration based filters in the redaction tool do not take accuracy into account enough #55

Open
AdamLeonSmith opened this issue Apr 18, 2020 · 2 comments

Comments

@AdamLeonSmith
Copy link
Contributor

The dataset I am using is me in my house for 2.5 hours with GPS / bluetooth switched on. Most of the data points correctly show in pink as I am in the same location. However, when I use the "Hide < 1hr" it hides all non-travel. I would expect that these locations would be identified as similar enough to be the same location, and therefore that I had been there over an hour, and would not be hidden.

Steps to reproduce:

@adityatr
Copy link

Looking at this issue right now: can reproduce the bug

@adityatr
Copy link

Update on this bug:

The reason for bug: The data is for 2.5 hrs, in between: you moved to a different location.

When we add a new marker to exposure Set we check the first location point of the last exposure set.

So if you are home: you stayed at home for 35 and 42 mins each, the gap was enough to create a new exposure set. SO total wasn't calculated properly we didn't put the two locations together.

The issue I am facing to fix this bug is:

  1. How many exposure sets do I compare before I plug values in the existing exposure set?
  2. how much time duration before we can say the location is actually new?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants