Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SSE codec #137

Open
ryanolson opened this issue Feb 8, 2025 · 1 comment
Open

Refactor SSE codec #137

ryanolson opened this issue Feb 8, 2025 · 1 comment
Labels
good first issue Good for newcomers

Comments

@ryanolson
Copy link
Contributor

          Can you add a `todo: consider refactor with https://github.com/launchdarkly/rust-eventsource-client/blob/main/eventsource-client/src/event_parser.rs` or something?

Originally posted by @rmccorm4 in #123 (comment)

@rmccorm4 rmccorm4 added the good first issue Good for newcomers label Feb 10, 2025
@paulhendricks
Copy link

Dove into this a bit and wanted to capture some findings.

eventsource-client

async-sse

tl;dr There may be some sense in continuing to roll our own SSE codec here, especially if we want custom functionality. What common structs exist in the Rust ecosystem like async-sse do not appear to be currently maintained or like eventsource-client do not appear to expose internal primitives we can use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants