Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Cleanup references to unused index dialect #5257

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[NFC] Cleanup references to unused index dialect #5257

merged 1 commit into from
Nov 25, 2024

Conversation

peterbell10
Copy link
Contributor

Also cleans up some includes clang thinks are unused.

@peterbell10
[NFC] Cleanup references to unused index dialect
388c4d8 
Also cleans up some includes clang thinks are unused.
@peterbell10 peterbell10 marked this pull request as ready for review November 25, 2024 19:52
ThomasRaoux
ThomasRaoux approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterbell10 peterbell10 merged commit c780bf4 into main Nov 25, 2024
7 checks passed
@peterbell10 peterbell10 deleted the pb/index-dialect-cleanup branch November 25, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasRaoux ThomasRaoux ThomasRaoux approved these changes

@antiagainst antiagainst antiagainst approved these changes

@zhanglx13 zhanglx13 Awaiting requested review from zhanglx13 zhanglx13 is a code owner

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterbell10 @antiagainst @ThomasRaoux