From 307915377fe78ad57e1acd9cfb98b8a0dbee85ce Mon Sep 17 00:00:00 2001 From: Daniel_Doehring Date: Wed, 18 Oct 2023 17:29:22 +0200 Subject: [PATCH] Add comments --- src/solvers/dgsem_tree/container_viscous_2d.jl | 5 ++++- src/solvers/dgsem_tree/container_viscous_3d.jl | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/solvers/dgsem_tree/container_viscous_2d.jl b/src/solvers/dgsem_tree/container_viscous_2d.jl index 57cb3728a11..bd7ff413af5 100644 --- a/src/solvers/dgsem_tree/container_viscous_2d.jl +++ b/src/solvers/dgsem_tree/container_viscous_2d.jl @@ -1,7 +1,10 @@ mutable struct ViscousContainer2D{uEltype <: Real} u_transformed::Array{uEltype, 4} # Using an outer fixed-size datastructure leads to nasty implementations, - # avoid this here. + # see https://github.com/trixi-framework/Trixi.jl/pull/1629#discussion_r1355293953. + # Also: This does not result in speed up compared to using tuples for the internal + # datastructures, see + # https://github.com/trixi-framework/Trixi.jl/pull/1629#discussion_r1363352188. gradients::Vector{Array{uEltype, 4}} flux_viscous::Vector{Array{uEltype, 4}} diff --git a/src/solvers/dgsem_tree/container_viscous_3d.jl b/src/solvers/dgsem_tree/container_viscous_3d.jl index 083bb5284a5..64d283fe189 100644 --- a/src/solvers/dgsem_tree/container_viscous_3d.jl +++ b/src/solvers/dgsem_tree/container_viscous_3d.jl @@ -1,7 +1,10 @@ mutable struct ViscousContainer3D{uEltype <: Real} u_transformed::Array{uEltype, 5} # Using an outer fixed-size datastructure leads to nasty implementations, - # avoid this here. + # see https://github.com/trixi-framework/Trixi.jl/pull/1629#discussion_r1355293953. + # Also: This does not result in speed up compared to using tuples for the internal + # datastructures, see + # https://github.com/trixi-framework/Trixi.jl/pull/1629#discussion_r1363352188. gradients::Vector{Array{uEltype, 5}} flux_viscous::Vector{Array{uEltype, 5}}