Skip to content

Commit

Permalink
Make PERK2 constructor consistent
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielDoehring committed Dec 1, 2024
1 parent 5266a6c commit ba49773
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
8 changes: 0 additions & 8 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,6 @@ Trixi.jl follows the interpretation of [semantic versioning (semver)](https://ju
used in the Julia ecosystem. Notable changes will be documented in this file
for human readability.

## Changes when updating to v0.10 from v0.9.x

#### Changed

- The `PairedExplicitRK2` constructor with second argument `base_path_monomial_coeffs::AbstractString` requires
now `dt_opt`, `b1`, `cS` to be given as keyword arguments ([#2184]).
Previously, those where standard function parameters, in the same order as listed above.

## Changes in the v0.9 lifecycle

#### Added
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ function compute_PairedExplicitRK2_butcher_tableau(num_stages,
end

@doc raw"""
PairedExplicitRK2(num_stages, base_path_monomial_coeffs::AbstractString; dt_opt = nothing,
PairedExplicitRK2(num_stages, base_path_monomial_coeffs::AbstractString, dt_opt = nothing,
bS = 1.0, cS = 0.5)
PairedExplicitRK2(num_stages, tspan, semi::AbstractSemidiscretization;
verbose = false, bS = 1.0, cS = 0.5)
Expand Down Expand Up @@ -143,7 +143,7 @@ mutable struct PairedExplicitRK2 <: AbstractPairedExplicitRKSingle
end # struct PairedExplicitRK2

# Constructor that reads the coefficients from a file
function PairedExplicitRK2(num_stages, base_path_monomial_coeffs::AbstractString;
function PairedExplicitRK2(num_stages, base_path_monomial_coeffs::AbstractString,
dt_opt = nothing,
bS = 1.0, cS = 0.5)
# If the user has the monomial coefficients, they also must have the optimal time step
Expand Down

0 comments on commit ba49773

Please sign in to comment.