From e108243a04db87b8756a2287ad380d4b3917ab8d Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Thu, 19 Oct 2023 23:24:13 +0200 Subject: [PATCH] Update src/solvers/dgsem_tree/dg_1d.jl Co-authored-by: Andrew Winters --- src/solvers/dgsem_tree/dg_1d.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/solvers/dgsem_tree/dg_1d.jl b/src/solvers/dgsem_tree/dg_1d.jl index e5a91fd3f8a..4a0747d1c09 100644 --- a/src/solvers/dgsem_tree/dg_1d.jl +++ b/src/solvers/dgsem_tree/dg_1d.jl @@ -146,7 +146,7 @@ end #= `weak_form_kernel!` is only implemented for conserved terms as -non-conserved terms are supposed to be always applied in conjunction with a flux-splitting scheme, +non-conservative terms should always be discretized in conjunction with a flux-splitting scheme, see `flux_differencing_kernel!`. This treatment is required to achieve, e.g., entropy-stability or well-balancedness. See also https://github.com/trixi-framework/Trixi.jl/issues/1671#issuecomment-1765644064