Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatching of analyze for parabolic terms #1347

Open
andrewwinters5000 opened this issue Feb 2, 2023 · 1 comment
Open

Dispatching of analyze for parabolic terms #1347

andrewwinters5000 opened this issue Feb 2, 2023 · 1 comment

Comments

@andrewwinters5000
Copy link
Member

Currently, in analysis.jl there are two versions of the analyze function. The original one (for the hyperbolic solver) dispatches only on semi::AbstractSemidiscretization. A new (experimental) version of analyze for the SemidiscretizationHyperbolicParabolic required the ability to unpack the equations_parabolic and cache_parabolic such that gradients were available to compute additional analysis quantities. In this case, the enstrophy.

The current strategy requires one to dispatch on the analysis quantity quantity::typeof(enstrophy) to avoid errors with the existing analysis quantities. This (cumbersome) way to dispatch on parabolic analysis quantities should be improved. See here for original discussion.

@DanielDoehring
Copy link
Contributor

Related: #1893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants