Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOML? Why? #150

Closed
PetrKryslUCSD opened this issue Sep 1, 2020 · 1 comment · Fixed by #200
Closed

TOML? Why? #150

PetrKryslUCSD opened this issue Sep 1, 2020 · 1 comment · Fixed by #200
Assignees
@ranocha

Comments

@PetrKryslUCSD
Copy link

A fantastic piece of work! And thanks for adding a reference to the JuliaPDE listing.

I am a bit puzzled why the simulations are described in the TOML files?
It would be equally legible, and more manageable, if the simulations
were described in pure Julia.
@ranocha
Copy link
Member

ranocha commented Sep 2, 2020

Thanks a lot!

The usage of TOML (parameter) files is a legacy from previous monolithic simulation codes written in FORTRAN. We've questioned a lot of old practices from these days in #42 and will move towards a more Julian way. It's good to know that you encourage doing this!

@ranocha ranocha self-assigned this Sep 2, 2020
@ranocha ranocha mentioned this issue Sep 9, 2020
Closed
14 tasks
@ranocha ranocha mentioned this issue Sep 22, 2020
Merged
36 tasks
@ranocha ranocha mentioned this issue Oct 6, 2020
Merged
45 tasks
ranocha added a commit that referenced this issue Nov 12, 2020
@ranocha
remove obsolete TOML parameter files; closes #150
ab42916
ranocha added a commit that referenced this issue Nov 12, 2020
@ranocha
remove obsolete TOML parameter files; closes #150
ab50f5d
@ranocha ranocha mentioned this issue Nov 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ranocha ranocha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge Taal into master trixi-framework/Trixi.jl
2 participants
@PetrKryslUCSD @ranocha