-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address type piracy related SummationByPartsOperators.jl and StartUpDG.jl #1639
Comments
They could basically be defined in a package extension for StartUpDg.jl, I think? |
Yes, that should work, but OTOH why the additional hassle? They do not depend on Trixi.jl types afaict, so they could just as well live in StartUpDG proper. |
But then StartUpDg.jl would need to depend on SummationByPartsOperators.jl without any real reason. Thus, we should either keep it like it is right now with type piracy where it is needed (in Trixi.jl) or make it a package extension. |
Ah, my bad, I thought it already was a dependency there. You're right, a Pkg extension seems the cleanest solution here. |
Closed by #1665 |
Originally posted by @sloede in #1628 (comment)
The SummationByPartsOperators.jl solvers specialize
RefElemData
,MeshData
, andestimate_h
from StartUpDG.jl, but do so in a way which is technically type piracy. See for exampleTrixi.jl/src/solvers/dgmulti/sbp.jl
Lines 62 to 64 in 92dedde
This type piracy can be addressed by moving these specializations into to StartUpDG.jl
The text was updated successfully, but these errors were encountered: