Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleAlgorithm3Sstar solve! call is allocating #1679

Closed
DanielDoehring opened this issue Oct 20, 2023 · 0 comments · Fixed by #1684
Closed

SimpleAlgorithm3Sstar solve! call is allocating #1679

DanielDoehring opened this issue Oct 20, 2023 · 0 comments · Fixed by #1684
Labels
performance We are greedy

Comments

@DanielDoehring
Copy link
Contributor

While tackling #1664 I observed that there are some allocations (most likely due to a type instability) in

Trixi.jl/src/time_integration/methods_3Sstar.jl

Line 205 in bb60b5d

function solve!(integrator::SimpleIntegrator3Sstar)

See https://github.com/trixi-framework/Trixi.jl/actions/runs/6574426931/job/17859448565#step:7:3563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance We are greedy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix type instability when iterating over callbacks in simple integrators trixi-framework/Trixi.jl
1 participant
@DanielDoehring