Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moist Euler equations with test case #1778

Open
5 of 8 tasks
benegee opened this issue Dec 18, 2023 · 3 comments
Open
5 of 8 tasks

Add moist Euler equations with test case #1778

benegee opened this issue Dec 18, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@benegee
Copy link
Contributor

benegee commented Dec 18, 2023

In the course of project ADAPTEX I would like to simulate the warm rising bubble test case in dry and moist air, described by Bryan and Fritsch (A Benchmark Simulation for Moist Nonhydrostatic Numerical Models, https://www.atmos.albany.edu/facstaff/rfovell/ATM562/bryan-fritsch-2002.pdf).

This has already been done by Lucas Gemein in his master's thesis, but was not merged into Trixi main.
His branch: https://github.com/NichtLucas/Trixi.jl/tree/thesis_gemein_2022
His PR: #1017
Oswald Knoth's PR: #171

ToDos:

@benegee benegee added the enhancement New feature or request label Dec 18, 2023
@benegee benegee self-assigned this Dec 18, 2023
@DanielDoehring
Copy link
Contributor

Possibly related: #171

@benegee
Copy link
Contributor Author

benegee commented Dec 18, 2023

Woohoo! Thanks for the hint. I had no idea how much stuff had already been around.

@DanielDoehring
Copy link
Contributor

Regarding the HLLC flux for non-cartesian meshes: I have a issue on this #1692 where I show my attempt (which is unfortunately wrong, but I cannot find the bug :( )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants