-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CI testing on Apple Silicon #1830
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
From here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just curious: why threaded_legacy
and not threaded
?
We need to remember to update the required checks when merging this.
This testset is not sufficient. It suggests that Trixi.jl is working on Apple Silicon, which is not the case. Many examples are still broken. |
Mostly because of this:
Originally posted by @efaulhaber in #1462 (comment) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1830 +/- ##
==========================================
- Coverage 96.38% 89.09% -7.29%
==========================================
Files 455 455
Lines 36391 36380 -11
==========================================
- Hits 35074 32410 -2664
- Misses 1317 3970 +2653
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jmark There are segfaults/SIGSEV for many |
No description provided.