Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI testing on Apple Silicon #1830

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

sloede
Copy link
Member

@sloede sloede commented Feb 5, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@sloede
Copy link
Member Author

sloede commented Feb 5, 2024

From here:

CPU: Apple M1 (Virtual)

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just curious: why threaded_legacy and not threaded?

We need to remember to update the required checks when merging this.

@efaulhaber
Copy link
Member

This testset is not sufficient. It suggests that Trixi.jl is working on Apple Silicon, which is not the case. Many examples are still broken.

@efaulhaber
Copy link
Member

Mostly because of this:

Note that when this is approved, the same should be done for the other indicators as well.

Originally posted by @efaulhaber in #1462 (comment)

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f7f058) 96.38% compared to head (2ec9ce1) 89.09%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1830      +/-   ##
==========================================
- Coverage   96.38%   89.09%   -7.29%     
==========================================
  Files         455      455              
  Lines       36391    36380      -11     
==========================================
- Hits        35074    32410    -2664     
- Misses       1317     3970    +2653     
Flag Coverage Δ
unittests 89.09% <ø> (-7.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ranocha
Copy link
Member

ranocha commented Feb 7, 2024

@jmark There are segfaults/SIGSEV for many t8code examples in our CI jobs, e.g.,
https://github.com/trixi-framework/Trixi.jl/actions/runs/7810133626/job/21303081900?pr=1830#step:7:1845
Do you have an idea what's going on?

@ranocha ranocha merged commit 3e6872b into main Feb 7, 2024
30 of 34 checks passed
@ranocha ranocha deleted the msl/run-ci-on-apple-silicon branch February 7, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants