Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of saving solution at irregularly spaced time intervals #2103

Open
knstmrd opened this issue Oct 9, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@knstmrd
Copy link

knstmrd commented Oct 9, 2024

Currently, SaveSolutionCallback accepts only either a fixed interval or a fixed dt parameter (i.e. outputting either at uniformly spaced timesteps or at uniformly spaced times).
From my experience it would be nice to have the option to pass in a list of output times which may be non-uniformly spaced (for example, in some reacting flow computations, a logarithmic timescale is really helpful as a lot of kinetics can slow down exponentially over time).

If there is interest in having such a feature (probably as an additional keyword in the SaveSolutionCallback initialization?) I could try my hand at implementing it.

@ranocha ranocha added the enhancement New feature or request label Oct 10, 2024
@ranocha
Copy link
Member

ranocha commented Oct 10, 2024

This would be nice! You can probably use

https://docs.sciml.ai/DiffEqCallbacks/stable/timed_callbacks/#DiffEqCallbacks.PresetTimeCallback

for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants