Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent non-conservative mortars #2130

Closed
amrueda opened this issue Oct 23, 2024 · 0 comments · Fixed by #2134
Closed

Inconsistent non-conservative mortars #2130

amrueda opened this issue Oct 23, 2024 · 0 comments · Fixed by #2134

Comments

@amrueda
Copy link
Contributor

amrueda commented Oct 23, 2024

The non-conservative mortar fluxes for P4estMesh{2}, T8codeMesh{2}, TreeMesh{2}, and TreeMesh{3} are currently computed on the small faces in the outward-pointing direction of the small elements only, neglecting the non-conservative (asymmetric) nature of these fluxes.

For example, the non-conservative calc_mortar_flux! for P4estMesh{2} (see here) computes a single non-conservative flux as follows:

noncons = nonconservative_flux(u_ll, u_rr, normal_direction, equations)

A unique flux per mortar interface (flux + 0.5 * noncons) is then projected/copied to the neighbor elements on both sides of the mortar by mortar_fluxes_to_elements! here.

A fix for the 3D p4est solver is done in #2127.

@andrewwinters5000 andrewwinters5000 linked a pull request Oct 29, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant