Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make T8CodeMesh (fully) type-general #2151

Closed
DanielDoehring opened this issue Nov 8, 2024 · 0 comments · Fixed by #2154
Closed

Make T8CodeMesh (fully) type-general #2151

DanielDoehring opened this issue Nov 8, 2024 · 0 comments · Fixed by #2154
Assignees
@jmark
Labels
consistency Make Michael happy

Comments

@DanielDoehring
Copy link
Contributor

Following upon #2128, #2136, #2129 the T8CodeMesh should also eliminate hard-codings to Float64 such as

Trixi.jl/src/solvers/dgsem_t8code/containers_2d.jl

Line 40 in 9fa4e27

element_coords = Array{Float64}(undef, 3)

Trixi.jl/src/solvers/dgsem_t8code/containers_3d.jl

Line 42 in 9fa4e27

element_coords = Vector{Float64}(undef, 3)

Trixi.jl/src/meshes/t8code_mesh.jl

Line 36 in 9fa4e27

mesh = new{NDIMS, Float64, typeof(is_parallel), NDIMS + 2, length(nodes)}(forest,

Trixi.jl/src/meshes/t8code_mesh.jl

Line 275 in 9fa4e27

reference_coordinates = Vector{Float64}(undef, 3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmark jmark

Labels
consistency Make Michael happy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make T8CodeMesh fully type general DanielDoehring/Trixi.jl
2 participants
@jmark @DanielDoehring