Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make linf_error computation @batch reduction=(max, linf_error) ready #2205

Open
DanielDoehring opened this issue Dec 12, 2024 · 0 comments
Open

Make linf_error computation @batch reduction=(max, linf_error) ready #2205

DanielDoehring opened this issue Dec 12, 2024 · 0 comments
Labels
parallelization Related to MPI, threading, tasks etc. performance We are greedy refactoring Refactoring code without functional changes

Comments

@DanielDoehring
Copy link
Contributor

DanielDoehring commented Dec 12, 2024 •
edited
Loading

The current implementation of the linf_error computation uses the broadcasted max operation.

Trixi.jl/src/callbacks_step/analysis_dg1d.jl

Line 111 in ab8ecad

linf_error = @. max(linf_error, abs(diff))

Unfortunately, Polyester.jl supports only the scalar max operation.

I would be nice to rewrite this in a way such that one could use the reduction operation from Polyester.jl .
@DanielDoehring DanielDoehring added performance We are greedy parallelization Related to MPI, threading, tasks etc. refactoring Refactoring code without functional changes labels Dec 12, 2024
@DanielDoehring DanielDoehring changed the title Make linf_error computation @batch reduction(max, linf_error) ready Make linf_error computation @batch reduction=(max, linf_error) ready Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
parallelization Related to MPI, threading, tasks etc. performance We are greedy refactoring Refactoring code without functional changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanielDoehring