From d54d6a4142e91d9de375bdea047007bc1eda60d0 Mon Sep 17 00:00:00 2001 From: Daniel_Doehring Date: Fri, 8 Mar 2024 11:38:36 +0100 Subject: [PATCH 1/3] Mention hyphen/dash caveat for boundary symbols --- docs/src/meshes/p4est_mesh.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/src/meshes/p4est_mesh.md b/docs/src/meshes/p4est_mesh.md index 3b35ffcad6f..6a21258d92c 100644 --- a/docs/src/meshes/p4est_mesh.md +++ b/docs/src/meshes/p4est_mesh.md @@ -256,6 +256,8 @@ By doing so, only nodesets with a label present in `boundary_symbols` are treate Other nodesets that could be used for diagnostics are not treated as external boundaries. Note that there is a leading colon `:` compared to the label in the `.inp` mesh file. This is required to turn the label into a [`Symbol`](https://docs.julialang.org/en/v1/manual/metaprogramming/#Symbols). +**Important**: In JUlia, a symbol _cannot_ contain a hyphen/dash `-`, i.e., `:BC-1` is _not_ a valid symbol. +Keep this in mind when importing boundaries, you might have to convert hyphens/dashes `-` to underscores `_`, i.e., `BC_1`. A 2D example for this mesh, which is read-in for an unstructured mesh file created with `gmsh`, is presented in `examples/p4est_2d_dgsem/elixir_euler_NACA6412airfoil_mach2.jl`. From 9504e4e2164064ccae228de1c1b9e308f8277dbd Mon Sep 17 00:00:00 2001 From: Daniel_Doehring Date: Fri, 8 Mar 2024 11:39:23 +0100 Subject: [PATCH 2/3] typo --- docs/src/meshes/p4est_mesh.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/meshes/p4est_mesh.md b/docs/src/meshes/p4est_mesh.md index 6a21258d92c..2740f335111 100644 --- a/docs/src/meshes/p4est_mesh.md +++ b/docs/src/meshes/p4est_mesh.md @@ -256,7 +256,7 @@ By doing so, only nodesets with a label present in `boundary_symbols` are treate Other nodesets that could be used for diagnostics are not treated as external boundaries. Note that there is a leading colon `:` compared to the label in the `.inp` mesh file. This is required to turn the label into a [`Symbol`](https://docs.julialang.org/en/v1/manual/metaprogramming/#Symbols). -**Important**: In JUlia, a symbol _cannot_ contain a hyphen/dash `-`, i.e., `:BC-1` is _not_ a valid symbol. +**Important**: In Julia, a symbol _cannot_ contain a hyphen/dash `-`, i.e., `:BC-1` is _not_ a valid symbol. Keep this in mind when importing boundaries, you might have to convert hyphens/dashes `-` to underscores `_`, i.e., `BC_1`. A 2D example for this mesh, which is read-in for an unstructured mesh file created with `gmsh`, is presented in From 0f5c63386272eb4e44ae1eb2706769b27c913a70 Mon Sep 17 00:00:00 2001 From: Daniel_Doehring Date: Fri, 8 Mar 2024 11:54:38 +0100 Subject: [PATCH 3/3] elaborate --- docs/src/meshes/p4est_mesh.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/meshes/p4est_mesh.md b/docs/src/meshes/p4est_mesh.md index 2740f335111..a14551b3f46 100644 --- a/docs/src/meshes/p4est_mesh.md +++ b/docs/src/meshes/p4est_mesh.md @@ -257,7 +257,7 @@ Other nodesets that could be used for diagnostics are not treated as external bo Note that there is a leading colon `:` compared to the label in the `.inp` mesh file. This is required to turn the label into a [`Symbol`](https://docs.julialang.org/en/v1/manual/metaprogramming/#Symbols). **Important**: In Julia, a symbol _cannot_ contain a hyphen/dash `-`, i.e., `:BC-1` is _not_ a valid symbol. -Keep this in mind when importing boundaries, you might have to convert hyphens/dashes `-` to underscores `_`, i.e., `BC_1`. +Keep this in mind when importing boundaries, you might have to convert hyphens/dashes `-` to underscores `_` in the `.inp` mesh file, i.e., `BC_1` instead of `BC-1`. A 2D example for this mesh, which is read-in for an unstructured mesh file created with `gmsh`, is presented in `examples/p4est_2d_dgsem/elixir_euler_NACA6412airfoil_mach2.jl`.