Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Octavian and matmul! #1950

Merged
merged 4 commits into from
May 23, 2024

Conversation

jlchan
Copy link
Contributor

@jlchan jlchan commented May 22, 2024

Would address #1906, and is the first step in addressing #1789.

Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@jlchan jlchan marked this pull request as draft May 22, 2024 18:55
@jlchan jlchan marked this pull request as ready for review May 22, 2024 18:59
@jlchan jlchan requested review from JoshuaLampert and ranocha and removed request for JoshuaLampert May 22, 2024 21:21
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.15%. Comparing base (887bab9) to head (9a567d7).

Additional details and impacted files
@@               Coverage Diff               @@
##           jc/dev_DGMulti    #1950   +/-   ##
===============================================
  Coverage           96.15%   96.15%           
===============================================
  Files                 454      454           
  Lines               36509    36509           
===============================================
+ Hits                35102    35103    +1     
+ Misses               1407     1406    -1     
Flag Coverage Δ
unittests 96.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlchan jlchan requested review from ranocha and removed request for ranocha May 23, 2024 00:10
@jlchan
Copy link
Contributor Author

jlchan commented May 23, 2024

@ranocha @JoshuaLampert I requested your reviews since you both commented on #1789. I am planning on merging PRs associated with this in a staging branch, and thought this might make it easier to review than a single large PR.

Let me know if you'd prefer to proceed otherwise

@jlchan
Copy link
Contributor Author

jlchan commented May 23, 2024

Is the MPI-macos test failure due to the Codecov issue when the PR is from a fork of the repo?

@ranocha
Copy link
Member

ranocha commented May 23, 2024

Is the MPI-macos test failure due to the Codecov issue when the PR is from a fork of the repo?

Yes, exactly. It would be easier if you could make the PRs from branches in the main repo

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine as a first step. Thanks

@ranocha ranocha merged commit 54f55e0 into trixi-framework:jc/dev_DGMulti May 23, 2024
35 of 36 checks passed
@JoshuaLampert
Copy link
Member

Thanks for taking care of this @jlchan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants