-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Documentation: Optimized Schemes, PERK Section, and PairedExplicitRK2 Tutorial #2146
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
I just saw that the numbers in front of the step instructions here are all 1, the same as the numbering in my locally rendered version. However, in the |
Seems like a markdown thing. Can you try to indent the code blocks in each of steps by four spaces? |
I think this might solve the problem but when I added the indentation, an error that I have been trying to fix shows up. I rechecked that all code blocks have consistent indentations but it still shows up:
|
I don't think we need the numbered list to show the steps the user needs to take if they want to use the integrator. If we need to explicitly name any step of the tutorial, we can simply just use a fifth-level heading. Let me know if you want anything else changed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine from my side if @DanielDoehring approves and the docs rendering has been checked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ready to be merged, @DanielDoehring?
Yes, good to go! Thanks @warisa-r and @JoshuaLampert, @ranocha ! |
Following the merge of #2008 and per @DanielDoehring's instructions, this pull request updates the documentation, especially in the file:
time_integration.md
to capture recent changes and improvements:PairedExplicitRK2
time integratorPlease let me know if you'd like any changes and improvements!
Xref: #21