Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle singularities in the correction matrix? #273

Closed
efaulhaber opened this issue Nov 6, 2023 · 3 comments
Closed

How to handle singularities in the correction matrix? #273

efaulhaber opened this issue Nov 6, 2023 · 3 comments

Comments

@efaulhaber
Copy link
Member

We didn't have this problem with TLSPH, but when using the correction matrix for WCSPH, for example for kernel gradient correction or density diffusion, it might become singular and can't be inverted.

How do we correctly handle this case? Set the inverse to zero? Or the identity? I chose the latter in #272.

@svchb
Copy link
Collaborator

svchb commented Nov 6, 2023

This is also related to #271 and #270. As well as adaptive support.

For now one can use the identity matrix. Setting the inverse to 0 is plainly wrong except for cases in which the matrix does not matter.

@svchb
Copy link
Collaborator

svchb commented Nov 6, 2023

In #261 it currently exits with an error.

@svchb
Copy link
Collaborator

svchb commented Nov 6, 2023

To merge #261 and #272 we should use similar conditions i.e. set the identity matrix for a critical condition number.

@svchb svchb closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants