Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Support for Julia 1.9 #672

Open
svchb opened this issue Nov 20, 2024 · 5 comments
Open

Drop Support for Julia 1.9 #672

svchb opened this issue Nov 20, 2024 · 5 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@svchb
Copy link
Collaborator

svchb commented Nov 20, 2024

Following things need to be changed to drop Julia 1.9:

@svchb svchb added bug Something isn't working dependencies Pull requests that update a dependency file labels Nov 20, 2024
@efaulhaber
Copy link
Member

And this can be removed:

if VERSION == v"1.10"
@test isapprox(error_edac_P1, 0, atol=eps())
@test isapprox(error_edac_P2, 0, atol=eps())
@test isapprox(error_wcsph_P1, 0, atol=eps())
@test isapprox(error_wcsph_P2, 0, atol=eps())
else
# 1.9 causes a large difference in the solution
# TODO 1.11 requires a performance hotfix which will likely change these results again
@test isapprox(error_edac_P1, 0, atol=4e-9)
@test isapprox(error_edac_P2, 0, atol=3e-11)
@test isapprox(error_wcsph_P1, 0, atol=26.3)
@test isapprox(error_wcsph_P2, 0, atol=8.2e-3)
end

@efaulhaber efaulhaber removed the bug Something isn't working label Jan 16, 2025
@efaulhaber
Copy link
Member

And the minimum version 1.9 is mentioned in the README and install.md.

@efaulhaber
Copy link
Member

I guess PointNeighbors.jl tests on 1.9 will also fail when TrixiParticles requires Julia 1.10. TrixiParticles is used as a test dependency to run the benchmarks.

This was referenced Jan 16, 2025
@sloede
Copy link
Member

sloede commented Jan 16, 2025

If you are dropping v1.9 support here, I'd definitely do it also for PN

@efaulhaber
Copy link
Member

See trixi-framework/PointNeighbors.jl#93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants