You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently have to duplicate some functionality, that is already implemented in Trixi.jl, such as for example the FluxHLL.
As discussed here it could be a good idea to introduce an additional abstraction layer to minimize the code duplication e.g. a function
@inline function (numflux::FluxHLL)(u_ll, u_rr, orientation_or_normal_direction,
equations::AbstractShallowWaterEquations{NDIMS})
that works for both the SWE in Trixi.jl and the SWEWD in TrixiShallowWater.jl.
However, when introducing this we need to be careful that these functions work for all sub-types.
The text was updated successfully, but these errors were encountered:
We currently have to duplicate some functionality, that is already implemented in
Trixi.jl
, such as for example theFluxHLL
.As discussed here it could be a good idea to introduce an additional abstraction layer to minimize the code duplication e.g. a function
that works for both the SWE in Trixi.jl and the SWEWD in TrixiShallowWater.jl.
However, when introducing this we need to be careful that these functions work for all sub-types.
The text was updated successfully, but these errors were encountered: