Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Trixi.jl compat bound to 0.8.6 #52

Merged

Conversation

patrickersing
Copy link
Contributor

This fixes the upper compat bound for Trixi.jl to the latest version 0.8.6 in order to merge trixi-framework/Trixi.jl#2038 without breaking CI.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.27%. Comparing base (cbc57dc) to head (e0c4a64).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          61       61           
  Lines        2638     2638           
=======================================
  Hits         2619     2619           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once the Trixi PR is merged we can then readjust the compat bounds right?

@patrickersing
Copy link
Contributor Author

LGTM. Once the Trixi PR is merged we can then readjust the compat bounds right?

Yes, since flux_nonconservative_ersing_etal is going to move from Trixi.jl to TrixiSW.jl we will have to set the compat bound to the new latest version.

@patrickersing patrickersing merged commit 38def64 into trixi-framework:main Aug 16, 2024
19 checks passed
@patrickersing patrickersing deleted the update_compat_bounds branch August 16, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants